8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) #11004

feilongjiang · 2022-11-05T03:48:01Z

Add experimental Foreign Function & Memory API support for RISC-V.

For details of the FFM API RISC-V port please refer to JBS issue

Testing:

jdk_foreign with release/fastdebug build on linux-riscv64
jdk_foreign with release/fastdebug build on linux-x64
jdk_foreign with release/fastdebug build on linux-aarch64

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)

Reviewers

Jorn Vernee (@JornVernee - Reviewer) ⚠️ Review applies to fee96ae8
Fei Yang (@RealFYang - Reviewer) ⚠️ Review applies to c4809317
Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to c4809317
Yadong Wang (@yadongw - Author)

Contributors

Weikai He <weikai@isrc.iscas.ac.cn>
Fei Yang <fyang@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11004/head:pull/11004
$ git checkout pull/11004

Update a local copy of the PR:
$ git checkout pull/11004
$ git pull https://git.openjdk.org/jdk pull/11004/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11004

View PR using the GUI difftool:
$ git pr show -t 11004

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11004.diff

bridgekeeper · 2022-11-05T03:49:26Z

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-05T03:52:04Z

@feilongjiang The following labels will be automatically applied to this pull request:

core-libs
hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

feilongjiang · 2022-11-08T01:32:15Z

/contributor add Weikai He weikai@isrc.iscas.ac.cn

openjdk · 2022-11-08T01:33:42Z

@feilongjiang
Contributor Weikai He <weikai@isrc.iscas.ac.cn> successfully added.

openjdk · 2022-12-13T13:41:33Z

@feilongjiang this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8293841-foreign-api-riscv
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

feilongjiang · 2022-12-19T14:11:05Z

/contributor add @RealFYang

openjdk · 2022-12-19T14:11:34Z

@feilongjiang
Contributor Fei Yang <fyang@openjdk.org> successfully added.

…841-foreign-api-riscv

JornVernee

Excellent. No Comments.

I am running some sanity testing on our CI, and will approve when it comes back green.

openjdk · 2023-01-14T10:22:31Z

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)

Co-authored-by: Weikai He <weikai@isrc.iscas.ac.cn>
Co-authored-by: Fei Yang <fyang@openjdk.org>
Reviewed-by: jvernee, fyang, shade, yadongwang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

8e3036c: 8300595: Use improved @see and @link syntax in javax.lang.model and javax.tools
715b509: 8298632: [TESTBUG] Add IR checks in jtreg vectorization tests
910dffe: 8292635: Run ArchivedEnumTest.java in jdk tier testing
fc9f8ba: Merge
b9275a8: 8300275: SegmentScope.isAccessibleBy returning incorrect values
c1b4212: 8300195: Fall-through issue occurs when using record pattern in switch statements
0f925fe: 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error
bd324ce: 8295687: Better BMP bounds
93161e4: 8293742: Better Banking of Sounds
6c5aefe: 8293554: Enhanced DH Key Exchanges
... and 26 more: https://git.openjdk.org/jdk/compare/15a9186db251f4be7a13e173842ac1bd858f984d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee, @RealFYang, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

test/jdk/java/foreign/callarranger/TestRISCV64CallArranger.java

…841-foreign-api-riscv

RealFYang

Looks good to me. This also passed tier1-4 tests on my HiFive Unmatched boards.

feilongjiang · 2023-01-17T01:57:35Z

Excellent. No Comments.

I am running some sanity testing on our CI, and will approve when it comes back green.

@JornVernee, Thanks for the review and performing sanity testing!

shipilev

Looks okay from the cursory review.

src/hotspot/cpu/riscv/codeBuffer_riscv.cpp

…841-foreign-api-riscv

yadongw

lgtm

feilongjiang · 2023-01-19T01:24:41Z

@JornVernee @RealFYang @shipilev @yadongw -- Thank you all for the review! I'm going to integrate it then.
/integrate

openjdk · 2023-01-19T01:26:27Z

@feilongjiang
Your change (at version feac5fa) is now ready to be sponsored by a Committer.

RealFYang · 2023-01-19T01:31:50Z

/sponsor

openjdk · 2023-01-19T01:33:44Z

Going to push as commit 24cdcd4.
Since your change was applied there have been 36 commits pushed to the master branch:

8e3036c: 8300595: Use improved @see and @link syntax in javax.lang.model and javax.tools
715b509: 8298632: [TESTBUG] Add IR checks in jtreg vectorization tests
910dffe: 8292635: Run ArchivedEnumTest.java in jdk tier testing
fc9f8ba: Merge
b9275a8: 8300275: SegmentScope.isAccessibleBy returning incorrect values
c1b4212: 8300195: Fall-through issue occurs when using record pattern in switch statements
0f925fe: 8295723: security/infra/wycheproof/RunWycheproof.java fails with Assertion Error
bd324ce: 8295687: Better BMP bounds
93161e4: 8293742: Better Banking of Sounds
6c5aefe: 8293554: Enhanced DH Key Exchanges
... and 26 more: https://git.openjdk.org/jdk/compare/15a9186db251f4be7a13e173842ac1bd858f984d...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-19T01:34:04Z

@RealFYang @feilongjiang Pushed as commit 24cdcd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

feilongjiang marked this pull request as draft November 5, 2022 03:48

openjdk bot added hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Nov 5, 2022

feilongjiang force-pushed the JDK-8293841-foreign-api-riscv branch from d5e2448 to 7006347 Compare December 13, 2022 13:39

openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Dec 13, 2022

feilongjiang force-pushed the JDK-8293841-foreign-api-riscv branch 2 times, most recently from 18c980f to 614882d Compare December 17, 2022 03:29

openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Dec 17, 2022

feilongjiang force-pushed the JDK-8293841-foreign-api-riscv branch from 614882d to 740665c Compare December 19, 2022 14:08

feilongjiang force-pushed the JDK-8293841-foreign-api-riscv branch 7 times, most recently from 4a35147 to 7a5de9a Compare December 27, 2022 09:43

feilongjiang force-pushed the JDK-8293841-foreign-api-riscv branch 7 times, most recently from effdf23 to bd943a5 Compare January 2, 2023 08:56

feilongjiang added 5 commits January 9, 2023 22:15

code adjustment and remove unnecessary static

1ad18c0

Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8293…

efe8238

…841-foreign-api-riscv

fix build

289b869

fix callArranger

fd31266

fix callArranger

fee96ae

JornVernee reviewed Jan 13, 2023

View reviewed changes

JornVernee approved these changes Jan 14, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 14, 2023

RealFYang suggested changes Jan 15, 2023

View reviewed changes

test/jdk/java/foreign/callarranger/TestRISCV64CallArranger.java Outdated Show resolved Hide resolved

feilongjiang added 3 commits January 15, 2023 23:24

Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8293…

3ad4679

…841-foreign-api-riscv

fix comment & code adjustment

be0826d

more code style adjustment

c480931

RealFYang approved these changes Jan 16, 2023

View reviewed changes

shipilev approved these changes Jan 17, 2023

View reviewed changes

src/hotspot/cpu/riscv/codeBuffer_riscv.cpp Show resolved Hide resolved

Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8293…

feac5fa

…841-foreign-api-riscv

yadongw approved these changes Jan 19, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 19, 2023

openjdk bot added the integrated Pull request has been integrated label Jan 19, 2023

openjdk bot closed this Jan 19, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 19, 2023

feilongjiang deleted the JDK-8293841-foreign-api-riscv branch January 31, 2023 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) #11004

8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) #11004

feilongjiang commented Nov 5, 2022 •

edited by openjdk bot

bridgekeeper bot commented Nov 5, 2022

openjdk bot commented Nov 5, 2022

feilongjiang commented Nov 8, 2022

openjdk bot commented Nov 8, 2022

openjdk bot commented Dec 13, 2022

feilongjiang commented Dec 19, 2022

openjdk bot commented Dec 19, 2022

JornVernee left a comment

openjdk bot commented Jan 14, 2023 •

edited

RealFYang left a comment •

edited

feilongjiang commented Jan 17, 2023 •

edited

shipilev left a comment

yadongw left a comment

feilongjiang commented Jan 19, 2023

openjdk bot commented Jan 19, 2023

RealFYang commented Jan 19, 2023

openjdk bot commented Jan 19, 2023

openjdk bot commented Jan 19, 2023

8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) #11004

8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) #11004

Conversation

feilongjiang commented Nov 5, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Contributors

Reviewing

bridgekeeper bot commented Nov 5, 2022

openjdk bot commented Nov 5, 2022

feilongjiang commented Nov 8, 2022

openjdk bot commented Nov 8, 2022

openjdk bot commented Dec 13, 2022

feilongjiang commented Dec 19, 2022

openjdk bot commented Dec 19, 2022

JornVernee left a comment

Choose a reason for hiding this comment

openjdk bot commented Jan 14, 2023 • edited

RealFYang left a comment • edited

Choose a reason for hiding this comment

feilongjiang commented Jan 17, 2023 • edited

shipilev left a comment

Choose a reason for hiding this comment

yadongw left a comment

Choose a reason for hiding this comment

feilongjiang commented Jan 19, 2023

openjdk bot commented Jan 19, 2023

RealFYang commented Jan 19, 2023

openjdk bot commented Jan 19, 2023

openjdk bot commented Jan 19, 2023

feilongjiang commented Nov 5, 2022 •

edited by openjdk bot

openjdk bot commented Jan 14, 2023 •

edited

RealFYang left a comment •

edited

feilongjiang commented Jan 17, 2023 •

edited