-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sealed interfaces marking operations that model a Java language construct #76
Conversation
with Java expressions and statements.
👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into |
@PaulSandoz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (I checked also all the ops in CoreOps to see they were covered).
/integrate |
@PaulSandoz Pushed as commit 650e4cf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Define two sealed interfaces
JavaExpression
andJavaStatement
. An operation implementingJavaExpression
models some Java expression. An operation implementingJavaStatement
models some Java statement. An operation implementing both models some expression statement e.g., a method invocation expression or statement.Not all operations implement these interfaces, they instead contribute to modeling Java program behavior and do not model a specific statement or expression. Operations modeling Java patterns are in a separate category.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/76/head:pull/76
$ git checkout pull/76
Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.org/babylon.git pull/76/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 76
View PR using the GUI difftool:
$ git pr show -t 76
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/76.diff
Webrev
Link to Webrev Comment