Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sealed interfaces marking operations that model a Java language construct #76

Closed

Conversation

PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented May 10, 2024

Define two sealed interfaces JavaExpression and JavaStatement. An operation implementing JavaExpression models some Java expression. An operation implementing JavaStatement models some Java statement. An operation implementing both models some expression statement e.g., a method invocation expression or statement.

Not all operations implement these interfaces, they instead contribute to modeling Java program behavior and do not model a specific statement or expression. Operations modeling Java patterns are in a separate category.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/76/head:pull/76
$ git checkout pull/76

Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.org/babylon.git pull/76/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 76

View PR using the GUI difftool:
$ git pr show -t 76

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/76.diff

Webrev

Link to Webrev Comment

with Java expressions and statements.
@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Sealed interfaces marking operations that model a Java language construct

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the code-reflection branch:

  • dd4adba: Implement bitwise/shift assignment operations
  • cf4cf1c: Fix triton example.

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@PaulSandoz PaulSandoz marked this pull request as ready for review May 16, 2024 19:23
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2024
@mlbridge
Copy link

mlbridge bot commented May 16, 2024

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I checked also all the ops in CoreOps to see they were covered).

@PaulSandoz
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit 650e4cf.
Since your change was applied there have been 2 commits pushed to the code-reflection branch:

  • dd4adba: Implement bitwise/shift assignment operations
  • cf4cf1c: Fix triton example.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@PaulSandoz Pushed as commit 650e4cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants