Add OPENHAB_BACKUPS environment variable #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Clark <ben@benjyc.uk>
ThomDietrich
reviewed
Aug 5, 2017
resources/etc/default/openhab2
Outdated
| # runtime/bin/backup and runtime/bin/restore will use this path for the zip files. | ||
| # | ||
| #OPENHAB_BACKUPS=/var/lib/openhab2/backups | ||
| # |
There was a problem hiding this comment.
Wondering if you want to move the EXTRA_JAVA_OPTS section to the bottom. Seems weird, that the file starts with that detail.
There was a problem hiding this comment.
I've left it at the top mainly because it's more likely for someone to want to edit it than any of the paths.
OPENHAB_BACKUPS however, would be a very commonly used variable, so perhaps it should be:
OPENHAB_BACKUPS
OPENHAB_USER
OPENHAB_GROUP
EXTRA_JAVA_OPTS
OPENHAB_STARTMODE
OPENHAB_*
Signed-off-by: Ben Clark <ben@benjyc.uk>
|
How about that? I kept USER and GROUP where it was because I wouldn't want to encourage anything other than |
ThomDietrich
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after openhab/openhab-distro#507
Signed-off-by: Ben Clark ben@benjyc.uk