Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airgradient] Add logo for recently added binding #2296

Merged
merged 2 commits into from
May 15, 2024

Conversation

austvik
Copy link
Contributor

@austvik austvik commented May 12, 2024

[airgradient] Add logo for recently added binding

Copy link

netlify bot commented May 12, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 15f587a
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/664251b7cf71020008e78212
😎 Deploy Preview https://deploy-preview-2296--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jlaur
Copy link
Contributor

jlaur commented May 13, 2024

@austvik - do you have an SVG version of the logo that could be used instead? See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@austvik
Copy link
Contributor Author

austvik commented May 13, 2024

Great! Added svg now.

I looked at this page where it wasn't mentioned as a possibility, but the original was svg so this is an improvement
https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The svg looks great. Thanks.

@stefan-hoehn stefan-hoehn added this to the 4.2 milestone May 14, 2024
@austvik
Copy link
Contributor Author

austvik commented May 14, 2024

I have checked the error and do not see how it is relevant for adding a .svg file:
"Error: developers/bindings/thing-xml.md:930:189 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 3]"

@stefan-hoehn
Copy link
Contributor

The error doesn't come from your PR - it is probably from somewhere else. I will merge anyway.

@stefan-hoehn stefan-hoehn merged commit f5f8cc4 into openhab:main May 15, 2024
4 of 5 checks passed
@austvik
Copy link
Contributor Author

austvik commented May 15, 2024

Thank you!

stefan-hoehn added a commit that referenced this pull request May 19, 2024
* Apply logo for free@home binding

Apply logo for free@home binding

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

* [sitemap] New Slider parameter releaseOnly (#2287)

* [saicismart][renault] Add addon SVG logo for Renault and SAIG MG Cars (#2290)

* [saicismart] Add addon logo for MG Cars from https://de.wikipedia.org/wiki/Datei:Mg_logo.svg

Signed-off-by: dougculnane <doug@culnane.net>

* [saicismart] Use SVG not PNG for addon logo

Signed-off-by: dougculnane <doug@culnane.net>

* [renault] Use SVG not PNG for addon logo

Signed-off-by: dougculnane <doug@culnane.net>

---------

Signed-off-by: dougculnane <doug@culnane.net>

* Update persistence actions docs (#2289)

* update persistence actions docs

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* correction

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* document HistoricItem

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* review adjustment

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

---------

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Update link to update-description-1.0.0.xsd (#2275)

The link for the update-description-1.0.0.xsd is wrong.

Signed-off-by: M Valla <12682715+mvalla@users.noreply.github.com>

* Replace logo of free@home binding with SVG version

Replace logo of free@home binding with SVG version

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

* [sitemap] Precision for Default element leading to Slider element (#2294)

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

* [sitemap] Press & release feature for buttons in a switch element (#2293)

Related to openhab/openhab-core#4183 and openhab/openhab-core#3822

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

* [airgradient] Add logo for recently added binding (#2296)

* [airgradient] Add logo for recently added binding

* Add airgradient logo in SVG format

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>

---------

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>

* [multimedia] Add record and transcribe commands (#2295)

* [multimedia] Add record and transcribe commands

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>

* apply pr review

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>

* fix md errors

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>

---------

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Co-authored-by: stefan-hoehn <mail@stefanhoehn.com>

* Apply logo for free@home binding

Apply logo for free@home binding

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

* Replace logo of free@home binding with SVG version

Replace logo of free@home binding with SVG version

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

---------

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: dougculnane <doug@culnane.net>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: M Valla <12682715+mvalla@users.noreply.github.com>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Co-authored-by: stefan-hoehn <mail@stefanhoehn.com>
Co-authored-by: mueller-ma <mueller-ma@users.noreply.github.com>
Co-authored-by: Doug Culnane <32482395+dougculnane@users.noreply.github.com>
Co-authored-by: Mark Herwege <mherwege@users.noreply.github.com>
Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com>
Co-authored-by: lolodomo <lg.hc@free.fr>
Co-authored-by: Jørgen Austvik <jaustvik@acm.org>
Co-authored-by: GiviMAD <GiviMAD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants