Add breaking change warning for openhab-js #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
reviewed
Apr 14, 2024
| @@ -134,6 +134,7 @@ ALERT;Twitter Binding has become X. All related references to Twitter and Tweets | |||
| ALERT;AndroidTV Binding: The thing configuration of 'port' has been renamed and split to 'googletvPort' and 'shieldtvPort' | |||
| ALERT;evcc Binding: Update to evcc API version 0.123.1 results in several new or updated channels. Existing Items will need to be adjusted. | |||
| ALERT;ISM8 Binding: Most channels have changed and are now using Units of Measurements. Items must be adapted and the things must be recreated. | |||
| ALERT;JavaScript Scripting Automation: The 'Item' suffix has been removed from Item.type, i.e. 'SwitchItem' becomes 'Switch'. | |||
There was a problem hiding this comment.
Can you also document the action users need to do e.g. update rules? Is this optional or mandatory?
There was a problem hiding this comment.
That’s quite difficult because there is much you can do with this.
E.g. for logging, this change doesn’t matter, but when using the equals operator to check for a given Item type, you would need to update one side of the comparison.
|
@florian-h05 can you please rebase? |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@holgerfriedrich Done 👍 |
|
Converting to draft as I will add more warnings soon. |
florian-h05
force-pushed
the
patch-1
branch
2 times, most recently
from
5b0af4e
to
e9e55c4
Compare
|
@kaikreuzer Can you please merge this PR for the next milestone? |
Refs https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#500. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
kaikreuzer
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#490
and https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#500.