Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added breaking change alert for evcc #1644

Merged
merged 2 commits into from Apr 7, 2024
Merged

Added breaking change alert for evcc #1644

merged 2 commits into from Apr 7, 2024

Conversation

MikeTheTux
Copy link
Contributor

@MikeTheTux
Added breaking change alert for evcc
bd628bb 
Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux MikeTheTux requested a review from a team as a code owner April 6, 2024 17:28
@MikeTheTux MikeTheTux mentioned this pull request Apr 6, 2024
Closed
holgerfriedrich
holgerfriedrich reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be in alphabetic order (not case sensitive).

distributions/openhab/src/main/resources/bin/update.lst Outdated Show resolved Hide resolved
@MikeTheTux
implemented review finding
07ff3e4 
Signed-off-by: Michael Weger <weger.michael@gmx.net>
holgerfriedrich
holgerfriedrich approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wborn
wborn approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@wborn wborn merged commit 466ca1b into openhab:main Apr 7, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeTheTux @holgerfriedrich @wborn