Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added breaking change for icalendar thing-split #1518

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daMihe
Copy link

@daMihe daMihe commented Apr 9, 2023

This PR depends on openhab/openhab-addons#14766.

It adds a message for the breaking change resulting from splitting the bridge into smaller things.

@daMihe daMihe requested a review from a team as a code owner April 9, 2023 18:32
@daMihe daMihe added the awaiting other PR Depends on another PR label Apr 9, 2023
@daMihe daMihe force-pushed the patch-1 branch 2 times, most recently from f1437d7 to 3ea880c Compare April 9, 2023 18:47
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be moved to the right OH version when it gets merged.

This PR depends on openhab/openhab-addons#14766.

Signed-off-by: Michael Wodniok <michi@noorganization.org>
Signed-off-by: Michael Wodniok <michi@noorganization.org>
@daMihe
Copy link
Author

daMihe commented Aug 6, 2023

Done. Added 4.1.0 section which may collide. If required i'll update again. I'm waiting for a review in the referenced PR.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is a 4.1.0 release now, it again should be moved to the right OH version when it gets merged.

@daMihe
Copy link
Author

daMihe commented Dec 23, 2023

Okay, i'll do when the code gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting other PR Depends on another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants