Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin translations #280

Merged
merged 150 commits into from Mar 13, 2018
Merged

New Crowdin translations #280

merged 150 commits into from Mar 13, 2018

Conversation

openhab-bot
Copy link
Collaborator

Enjoy!

Copy link
Member

@martinvw martinvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, shall we merge this first batch?

@martinvw
Copy link
Member

@ThomDietrich

@ThomDietrich
Copy link
Member

@martinvw did you test them? See my previous comment:

The newly introduced escape sequences in dashboard.properties could create issues but can be configured. Could any of you check if e.g. the french translation file presents correctly as it is right now?

After that I'd be fine to merge!

@martinvw
Copy link
Member

@wborn if you have time now, it would be awesome if you could test this :-)

@wborn
Copy link
Member

wborn commented Mar 12, 2018

After making a local build all the translations showed up as expected! 👍

French

DashboardHome Builder

Russian

DashboardHome Builder

Other thoughts

The dashboard translations are only picked up after you have configured a language via Paper UI. So it looks like currently users will never see all those setup text translations. Is the language going to be auto detected using the browser request headers someday?

@martinvw
Copy link
Member

The dashboard translations are only picked up after you have configured a language via Paper UI. So it looks like currently users will never see all those setup text translations. Is the language going to be auto detected using the browser request headers someday?

I remember a long discussion about this, I think this the proper reference: #217 (comment)

@martinvw martinvw merged commit aa899d7 into master Mar 13, 2018
@martinvw
Copy link
Member

@ThomDietrich sorry that it took so long, should we now just wait a day or so and create a new PR from the same branch?

@ThomDietrich ThomDietrich deleted the l10n-crowdin branch March 13, 2018 13:45
@ThomDietrich
Copy link
Member

ThomDietrich commented Mar 13, 2018

@martinvw Verry happy to see progress here :) No worries. We all have other obligations aside the openHAB world.
Crowdin will create a new branch and PR as soon as new additions are made. We don't have to do anything.

@wborn thanks for testing!

On another note: Please check out https://github.com/openhab/openhab-core/issues/314

@wborn wborn added this to the 2.3 milestone Feb 28, 2019
Rosi2143 pushed a commit to Rosi2143/openhab-core that referenced this pull request Dec 26, 2020
* Factor OH1 addon docs into site, filter lists by source and install status.  Fixes openhab#280

Signed-off-by: John Cocula <john@cocula.com> (github user: watou)

* Fixed typos.

* Add title to front matter for add-ons readmes that don’t already have front matter.

Also clean up new doc directories.

* Add warning comment in modified readmes

* Don’t remove “Persistence” from “Java Persistence API”

* address comments

Signed-off-by: John Cocula <john@cocula.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants