[compat1x] Fix ChartProvider API break #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESH PR 4291 introduced a change in the ChartProvider API. This commit changes the compat1x ChartProviderDelegate to work with these changes. Signed-off-by: Holger Reichert <mail@h0lger.de>
This was referenced Sep 25, 2017
|
Travis build is failing because it builds against the current ESH stable version, that does not contain the changes from eclipse-archived/smarthome#4291 yet. |
|
ESH Stable has been built, Travis is green 👍 |
Rosi2143
pushed a commit
to Rosi2143/openhab-core
that referenced
this pull request
Dec 26, 2020
Signed-off-by: Thomas Dietrich <thomas.dietrich@tu-ilmenau.de> (github: ThomDietrich)
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
The ESH PR 4291 introduced a change in the ChartProvider API. This commit changes the compat1x ChartProviderDelegate to work with these changes. Signed-off-by: Holger Reichert <mail@h0lger.de> GitOrigin-RevId: d5841d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESH PR eclipse-archived/smarthome#4291 introduced a change in the ChartProvider API.
This commit changes the compat1x
ChartProviderDelegateto compile with these changes.This should be merged when a new ESH stable is built, otherwise it would cause build failure of
openhab-core.