[basicprofiles] Initial contribution #16754
Merged
+3,240
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A set of basic profiles with general use cases. See documentation for details. Also-By: Christoph Weitkamp <github@christophweitkamp.de> Also-By: Arne Seime <arne.seime@gmail.com> Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
requested changes
May 21, 2024
There was a problem hiding this comment.
Thanks, I like this! I have added a few minor comments, otherwise LGTM.
I did a quick check on our discussion in #14529, and I think the main concern was the UI not being prepared for having many new profiles once a bundle like this is installed?
I compiled the profile, and it doesn't look very crowded to me yet for the few different item types I checked. @kaikreuzer - would you agree that in relation to your comment, this is not "uncontrolled growth"? 🙂
...main/java/org/openhab/transform/basicprofiles/internal/profiles/TimeRangeCommandProfile.java
Outdated
Show resolved
Hide resolved
...g.openhab.transform.basicprofiles/src/main/resources/OH-INF/i18n/basicprofiles_de.properties
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/openhab/transform/basicprofiles/internal/profiles/RoundStateProfile.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/openhab/transform/basicprofiles/internal/profiles/RoundStateProfile.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/InvertStateProfile.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/InvertStateProfile.java
Outdated
Show resolved
Hide resolved
...java/org/openhab/transform/basicprofiles/internal/profiles/GenericCommandTriggerProfile.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openhab/transform/basicprofiles/internal/factory/BasicProfilesFactory.java
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
reviewed
May 24, 2024
bundles/org.openhab.transform.basicprofiles/src/main/resources/OH-INF/addon/addon.xml
Show resolved
Hide resolved
…/OH-INF/addon/addon.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: J-N-K <github@klug.nrw>
Sure, all fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of basic profiles with general use cases. See documentation for details.
This was originally contributed and forked from https://github.com/smarthomej/addons
Also-By: Christoph Weitkamp github@christophweitkamp.de
Also-By: Arne Seime arne.seime@gmail.com