Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buttongrid README examples #16701

Merged
merged 6 commits into from May 4, 2024
Merged

Add Buttongrid README examples #16701

merged 6 commits into from May 4, 2024

Conversation

mlobstein
Copy link
Contributor

Add Buttongrid examples to the README of benqprojector, epsonprojector, oppo, panasonicbdp, roku, tivo & vizio bindings.

@mlobstein
Add Buttongrid readme examples
5be1b99 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein requested a review from jimtng April 29, 2024 00:59
@mlobstein
fix epson
32ff5a4 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@lolodomo
Copy link
Contributor

Please extract the changes in TIVO binding that are not documentation in a separate PR.

@mlobstein
remove tivo changes
52ad3bf 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein
review changes
70029df 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein
tweak whitespace
5ae6a8c 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@lolodomo
Copy link
Contributor

lolodomo commented May 4, 2024

Just a suggestion: rather the OH icon "screen" representing a TV, you could for example propose the icon "material:tv_remote" representing a remote control.

@lolodomo
Copy link
Contributor

lolodomo commented May 4, 2024

I will probably propose an example for the Rotel binding.

@mlobstein
review changes
b459502 
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein
Copy link
Contributor Author

Just a suggestion: rather the OH icon "screen" representing a TV, you could for example propose the icon "material:tv_remote" representing a remote control.

got it, thanks!

jlaur
jlaur approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur
Copy link
Contributor

jlaur commented May 4, 2024

I will probably propose an example for the Rotel binding.

For this PR, or will you create a separate one? If you are fine with this PR, feel free to merge.

@lolodomo
Copy link
Contributor

lolodomo commented May 4, 2024

or will you create a separate one?

Later in a separate PR.
So you can merge this one.

@jlaur jlaur merged commit 1ef13c6 into openhab:main May 4, 2024
5 checks passed
@jlaur jlaur added this to the 4.2 milestone May 4, 2024
@mlobstein mlobstein deleted the readme_buttongrid branch May 4, 2024 23:09
@mlobstein
Copy link
Contributor Author

@jimtng Perhaps you could update the first post in your thread to list these bindings that now have Buttongrid examples in the documentation?
https://community.openhab.org/t/tv-remote-control-on-basicui-thanks-to-buttongrid/152696

@jimtng
Copy link
Contributor

jimtng commented May 5, 2024

I've updated the forum post, but I noticed that lgwebos is missing from this PR, and perhaps also for other TV bindings?

@lolodomo
Copy link
Contributor

lolodomo commented May 5, 2024

I am going to propose one for lgwebos.

@mlobstein mlobstein mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@jimtng jimtng Awaiting requested review from jimtng

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mlobstein @lolodomo @jlaur @jimtng