Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tradfri] Adapt tests to ColorUtil changes on core #16699

Merged
merged 1 commit into from Apr 28, 2024

Conversation

holgerfriedrich
Copy link
Member

openhab/openhab-core#4124 changed the implementation of color conversions slightly.
As tradfri has some test checking the values for known colors, those need to be adapted (slightly!).

This currently breaks the CI build.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 1af3ecd into openhab:main Apr 28, 2024
5 checks passed
@lolodomo lolodomo added the test label Apr 28, 2024
@lolodomo lolodomo added this to the 4.2 milestone Apr 28, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Apr 28, 2024

@andrewfg fyi

@holgerfriedrich holgerfriedrich deleted the pr-tradfri-color branch April 28, 2024 22:47
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants