New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[airq] Add health/performance channels in percent, add UoM, refine unit hints and state patterns, make item labels consistent #16698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwolter
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Apr 28, 2024
fwolter
force-pushed
the
airq-refine-h2s
branch
from
April 28, 2024 19:53
ffdf796
to
ca0fc45
Compare
J-N-K
reviewed
Apr 28, 2024
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
J-N-K
reviewed
Apr 28, 2024
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
J-N-K
reviewed
Apr 28, 2024
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
J-N-K
reviewed
Apr 28, 2024
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
J-N-K
reviewed
Apr 28, 2024
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
J-N-K
reviewed
Apr 28, 2024
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Please rebase now the other PR is merged. You might need to look into the thingtypeversion as version 1 is allready merged. (did not look if they are about the same Thing) |
…it hints and state patterns, make item labels consistent Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
I added the update instructions. Thank you both for pointing that out! |
lsiepel
reviewed
May 1, 2024
lsiepel
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #16696.