[denonmarantz] Improve discovery #16692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a few discovery improvements:
am
property. This fixes the vendor property being set to Marantz for Denon receivers.The UPnP discovery is now in sync with the suggestion add-on definition (see #16035):
openhab-addons/bundles/org.openhab.binding.denonmarantz/src/main/resources/OH-INF/addon/addon.xml
Lines 12 to 20 in 229c2b7
I have only been able to test this with a very old and very new Denon receiver. If the new assumption about brand string (Denon/Marantz) being part of the model name does not hold for all receivers, the vendor property may not be set.
The mDNS name used for the label should be safe as already described as containing both vendor and model ("Marantz SR5008"):
openhab-addons/bundles/org.openhab.binding.denonmarantz/src/main/java/org/openhab/binding/denonmarantz/internal/discovery/DenonMarantzDiscoveryParticipant.java
Lines 47 to 54 in 229c2b7
Discovery results for my receivers (first is mDNS, second is UPnP):
Resolves #16690