[gridbox] Initial contribution #16664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
jlaur
added
the
new binding
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
jlaur
reviewed
Apr 20, 2024
There was a problem hiding this comment.
Thanks for your contribution!
Just one quick comment: The CI build might work better if you add your binding to this POM:
https://github.com/openhab/openhab-addons/blob/main/bom/openhab-addons/pom.xml
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
|
Should be done now 👍 I think the build error was because I messed up the bundles/pom.xml formatting... But I added the binding to the bom pom.xml as well. Maybe this would be an improvement to the create_openhab_binding_skeleton skripts? |
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
lsiepel
requested changes
Apr 27, 2024
There was a problem hiding this comment.
Nice contribution, thanks. Many comments are the same issue, so it is allready in a good shape.
You could also consider to support i18n with the updatestatus detail text. But that is up to you, updateStatus example here: https://www.openhab.org/docs/developer/utils/i18n.html#using-custom-keys
Also unit tests are highly appreciated (not mandatory). See other bindings for some examples.
bundles/org.openhab.binding.gridbox/src/main/resources/OH-INF/addon/addon.xml
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/api/GridBoxApi.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/api/GridBoxApi.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/api/GridBoxApi.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/api/GridBoxApi.java
Outdated
Show resolved
Hide resolved
...ding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxBindingConstants.java
Outdated
Show resolved
Hide resolved
lsiepel
changed the title
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
lsiepel
requested changes
Apr 28, 2024
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/GridBoxHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/api/GridBoxApi.java
Outdated
Show resolved
Hide resolved
...enhab.binding.gridbox/src/main/java/org/openhab/binding/gridbox/internal/api/GridBoxApi.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.gridbox/src/main/resources/OH-INF/i18n/gridbox.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
lsiepel
approved these changes
May 5, 2024
Signed-off-by: Benedikt Kuntz <benkuntz@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viessmann GridBox Binding
Initial contribution for a new binding for connecting to the Viessmann GridBox, see README.MD for information about it
Description
My first contribution, be merciful ;) Only tested with my private setup, any comments or testing highly appreciated...