[ipcamera] Fix Reolink Duo Floodlight whiteLED Channel #16663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unable to asses if these changed modes are good. Code is fine. Need @Skinah to determine if this is ok to merge. In the mean time it would be nice if you can fix the DCO. |
light is turned on, it will stay on forever and if the light is turned off, it will stay off forever. Signed-off-by: Simmon Yau <simmonyau@gmail.com>
simmonyau
force-pushed
the
reolink-fix-duo-floodlight
branch
from
9688429
to
8ba123a
Compare
Done. |
|
Gentle ping @Skinah |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated whiteLED channel for reolink ipcamera so that when the light is turned on, it will stay on forever and if the light is turned off, it will stay off forever. This is achieved by setting the floodlight mode to "Always On at Night" when the floodlight is turned on and to Off when the floodlight is turned off. Prior to this change, the mode would be set to Auto when turning the floodlight off and to Off when setting the floodlight ON and then back to Auto if you change the brightness via the dimmer.
This was tested and confirmed on a Reolink Duo Floodlight POE camera and is working well for me. I believe this setting would be more ideal for most users but I could be wrong. I just thought it was odd that the floodlight wouldn't stay on longer than 3 minutes after the brightness was set to 100. The same thing probably could have been achieved if mode is set to 0 for all 3 settings.
Signed-off-by: Simmon Yau simmonyau@gmail.com