Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Add support for Shelly Plus HT Gen3 #16625

Merged
merged 3 commits into from May 11, 2024
Merged

[shelly] Add support for Shelly Plus HT Gen3 #16625

merged 3 commits into from May 11, 2024

Conversation

markus7017
Copy link
Contributor

This PR adds support for the new Shelly Plus HT 3

@markus7017
Add support for Shelly Plus HT Gen3
e7c7639 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 added the enhancement An enhancement or new feature for an existing add-on label Apr 7, 2024
@markus7017 markus7017 self-assigned this Apr 7, 2024
@jlaur jlaur changed the title [shelly[ Support for Shelly Plus HT Gen3 [shelly] Support for Shelly Plus HT Gen3 Apr 7, 2024
jlaur
jlaur requested changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added a few minor comments.

...inding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyDeviceProfile.java Outdated Show resolved Hide resolved
....binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiClient.java Outdated Show resolved Hide resolved
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java Outdated Show resolved Hide resolved
@markus7017
review changes applued, Shelly Plus UI added to README
467b2e7 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

@jlaur review changes applied

jlaur
jlaur requested changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing review comments. I have added a few very minor ones after last commit.

bundles/org.openhab.binding.shelly/README.md Show resolved Hide resolved
....binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiClient.java Outdated Show resolved Hide resolved
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java Show resolved Hide resolved
@markus7017
review changes applied
ff1a987 
Signed-off-by: Markus Michels <markus7017@gmail.com>
jlaur
jlaur approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 7a32f4e into openhab:main May 11, 2024
5 checks passed
@jlaur jlaur added this to the 4.2 milestone May 11, 2024
@jlaur jlaur changed the title [shelly] Support for Shelly Plus HT Gen3 [shelly] Add support for Shelly Plus HT Gen3 May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees

@markus7017 markus7017

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markus7017 @jlaur