New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[huesync][WIP] Hue Play HDMI Sync Box Binding - Initial contribution #16516
Open
pgfeller
wants to merge
42
commits into
openhab:main
Choose a base branch
from
pgfeller:10218-hue-add-hue-sync-box
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgfeller
added
new binding
If someone has started to work on a binding. For a new binding PR.
work in progress
A PR that is not yet ready to be merged
labels
Mar 12, 2024
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/philips-hdmi-sync-api/111679/39 |
pgfeller
force-pushed
the
10218-hue-add-hue-sync-box
branch
2 times, most recently
from
March 12, 2024 23:41
edf4eb7
to
565fc72
Compare
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
… device Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
…formation Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@gmail.com>
@pgfeller I will start to look at this tomorrow. |
pgfeller
force-pushed
the
10218-hue-add-hue-sync-box
branch
from
March 12, 2024 23:57
565fc72
to
ba801a2
Compare
@andrewfg Thanks! Take your time - progress will be slow unfortunately; as free time is a rare commodity ... |
andrewfg
reviewed
Mar 18, 2024
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…he needless cost of parameter construction. Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…he needless cost of parameter construction. Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…tation tasks Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
andrewfg
reviewed
Apr 10, 2024
.../java/org/openhab/binding/huesync/internal/api/dto/device/HueSyncDeteiledDeviceInfoWifi.java
Outdated
Show resolved
Hide resolved
andrewfg
reviewed
Apr 10, 2024
...huesync/src/main/java/org/openhab/binding/huesync/internal/connection/HueSyncConnection.java
Show resolved
Hide resolved
andrewfg
reviewed
Apr 10, 2024
...huesync/src/main/java/org/openhab/binding/huesync/internal/connection/HueSyncConnection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
andrewfg
reviewed
Apr 12, 2024
...huesync/src/main/java/org/openhab/binding/huesync/internal/connection/HueSyncConnection.java
Outdated
Show resolved
Hide resolved
…psulation to simplify null handling and annotation Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…... 🤔 - wip? Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…ration (wip) - 💣 preparation for connection exceptions - 📜 preparation for channel .xml's BREAKING CHANGE: Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
- current firmware (read only) - available/latest firmware (read only) 📜 minor improvements and refactoring ... (wip) Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller
force-pushed
the
10218-hue-add-hue-sync-box
branch
from
May 3, 2024 22:38
5c6c239
to
a4e7e94
Compare
- keep firmware property and channel in sync - README.md updated Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller
force-pushed
the
10218-hue-add-hue-sync-box
branch
from
May 7, 2024 19:55
186bd73
to
0549ac6
Compare
📜 includes some refactoring (rename of classes and device status callback type) Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new binding
If someone has started to work on a binding. For a new binding PR.
work in progress
A PR that is not yet ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binding integrates the Play HDMI Sync Box into openHAB. The integration happens directly through the Hue HDMI Sync Box API.
The beinding is using mDNS to discover HDMI Sync devies in the local network. The LED on the Sync Box must be white or red. This indicates that the device is connected to the Network. If the LED is blinking blue, you need to setup the device using the official Hue Sync App.
Community discussion thread: Philips HDMI Sync API
Closes #10218
Credits
The code is based on the work done by Marco Kawon - but the code is refactored. Feedback is very welcome. The refactoring is done to implement functionality step-by-step, so that I understand the code and in the hope to simplify it a bit (e.g. the
json
serialization).Tasks
AuthenticationStore
✅