[PJLinkDevice] audio/video mute #16504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils
force-pushed
the
audiovideomute
branch
3 times, most recently
from
5997a22
to
7c428ea
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
|
Tested successfully using the PJLinkTEST4CNT application. Ready to be reviewed 🙂 |
lolodomo
added
the
enhancement
|
As you add a new channel, please provide upgrade instructions. |
|
Do you have an example of what needs to be considered for an upgrade when adding a channel? |
|
It is documented in details ... but I don't find the page anymore! |
lolodomo
requested changes
Mar 16, 2024
| @@ -103,6 +104,12 @@ | |||
| <description>Select the video mute status</description> | |||
| </channel-type> | |||
|
|
|||
| <channel-type id="audioAndVideoMute"> | |||
There was a problem hiding this comment.
In addition to provide upgrade instructions for the thing, please also regenerate the i18n file to include your new channel: mvn i18n:generate-default-translations
|
Gentel ping @nils do you need anything to proceed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested on the community.