[emotiva] Initial contribution #16499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/emotiva-av-processor-binding/154406/1 |
mlobstein
added
the
new binding
|
The build is failing because your commit it not signed. See here for instructions to fix it: https://github.com/openhab/openhab-addons/pull/16499/checks?check_run_id=22412921872 |
espenaf
force-pushed
the
emotiva
branch
3 times, most recently
from
eca824b
to
e3162e3
Compare
espenaf
force-pushed
the
emotiva
branch
2 times, most recently
from
3793c64
to
969b223
Compare
austvik
reviewed
Apr 1, 2024
bundles/org.openhab.binding.anel/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
austvik
reviewed
Apr 1, 2024
...inding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaCommandHandler.java
Outdated
Show resolved
Hide resolved
...inding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaCommandHandler.java
Outdated
Show resolved
Hide resolved
| "@text/message.processor.connection.failed"); | ||
| disconnect(); | ||
| scheduleConnectRetry(retryConnectInMinutes); | ||
| } |
There was a problem hiding this comment.
Thinking out loud: could (some of) this status updating be moved to handleStatusUpdate()?
There was a problem hiding this comment.
Not sure, the connection method is synchronized and try to make sure the connection is either working or we need to schedule a retry. Suggestions are welcome.
...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java
Show resolved
Hide resolved
...tiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaControlCommands.java
Show resolved
Hide resolved
...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaDataType.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.emotiva/src/main/resources/OH-INF/config/config.xml
Show resolved
Hide resolved
espenaf
force-pushed
the
emotiva
branch
3 times, most recently
from
bf10246
to
612fde5
Compare
espenaf
changed the title
Signed-off-by: Espen Fossen <espenaf@junta.no>
lsiepel
reviewed
May 10, 2024
There was a problem hiding this comment.
Thanks for this contribution. Looked at all except the key controller/handlers, will do in a next round.
For each comment, try to check if it can also apply to other parts of the code.
Please check that al SAT errors are fxied and the build comes without any warnings.
| xsi:schemaLocation="https://openhab.org/schemas/thing-description/v1.0.0 https://openhab.org/schemas/thing-description-1.0.0.xsd"> | ||
|
|
||
| <thing-type id="processor"> | ||
| <label>Emotiva Processor Binding Thing</label> |
There was a problem hiding this comment.
Suggested change
| <label>Emotiva Processor Binding Thing</label> | |
| <label>Emotiva Processor</label> |
| </channel-group> | ||
| <channel-group id="zone2" typeId="zone"> | ||
| <label>Zone 2 Control</label> | ||
| <description>Channels for zone2 of this processor.</description> |
There was a problem hiding this comment.
Suggested change
| <description>Channels for zone2 of this processor.</description> | |
| <description>Channels for zone 2 of this processor.</description> |
bundles/org.openhab.binding.emotiva/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
| <label>General Control</label> | ||
| <description>General channels for this processor.</description> | ||
| <channels> | ||
| <channel id="power" typeId="mainPower"/> |
There was a problem hiding this comment.
Please adapt all channel names and types to the naming convention.
Details here:
https://www.openhab.org/docs/developer/guidelines.html#naming-convention
| <channel-type id="dim"> | ||
| <item-type>Number:Percentage</item-type> | ||
| <label>Front Panel Dimness</label> | ||
| <description>Percentage of dimness: "0", "20", "40", "60", "80", "100"</description> |
There was a problem hiding this comment.
If ony those presets are possible, you could provide an option list
There was a problem hiding this comment.
The dim command only cycles through these values, so one cannot select a specific value.
| <name>Emotiva Binding</name> | ||
| <description>This is the binding for devices from the Emotiva Audio Corporation.</description> | ||
| <connection>local</connection> | ||
|
|
There was a problem hiding this comment.
Would be nice if this can be extended with suggestion finder details
https://www.openhab.org/docs/developer/addons/addon.html#discovery-methods
Comment on lines
+15
to
+36
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_SOURCE; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_TUNER_BAND; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_TUNER_CHANNEL_SELECT; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_ZONE2_SOURCE; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_TRIM_MAX_DECIBEL; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_TRIM_MIN_DECIBEL; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_VOLUME_MAX_DECIBEL; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_VOLUME_MIN_DECIBEL; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.MAP_SOURCES_MAIN_ZONE; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.MAP_SOURCES_ZONE_2; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.PROTOCOL_V3_LEVEL_MULTIPLIER; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.TRIM_SET_COMMAND_SUFFIX; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaCommandHelper.clamp; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaCommandHelper.volumePercentageToDecibel; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.NUMBER; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.SET; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.TOGGLE; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.UP_DOWN_HALF; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.UP_DOWN_SINGLE; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaDataType.FREQUENCY_HERTZ; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaSubscriptionTags.tuner_band; | ||
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaSubscriptionTags.tuner_channel; |
There was a problem hiding this comment.
Suggested change
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_SOURCE; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_TUNER_BAND; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_TUNER_CHANNEL_SELECT; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.CHANNEL_ZONE2_SOURCE; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_TRIM_MAX_DECIBEL; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_TRIM_MIN_DECIBEL; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_VOLUME_MAX_DECIBEL; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DEFAULT_VOLUME_MIN_DECIBEL; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.MAP_SOURCES_MAIN_ZONE; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.MAP_SOURCES_ZONE_2; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.PROTOCOL_V3_LEVEL_MULTIPLIER; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.TRIM_SET_COMMAND_SUFFIX; | |
| import static org.openhab.binding.emotiva.internal.EmotivaCommandHelper.clamp; | |
| import static org.openhab.binding.emotiva.internal.EmotivaCommandHelper.volumePercentageToDecibel; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.NUMBER; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.SET; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.TOGGLE; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.UP_DOWN_HALF; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaCommandType.UP_DOWN_SINGLE; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaDataType.FREQUENCY_HERTZ; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaSubscriptionTags.tuner_band; | |
| import static org.openhab.binding.emotiva.internal.protocol.EmotivaSubscriptionTags.tuner_channel; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.* | |
| import static org.openhab.binding.emotiva.internal.protocol.* |
| } | ||
|
|
||
| public EmotivaControlDTO createDTO(Command ohCommand, @Nullable State previousState) { | ||
|
|
| } | ||
| case UP_DOWN_HALF -> { | ||
| if (ohCommand instanceof Number value) { | ||
|
|
Comment on lines
+15
to
+17
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DISCOVERY_BROADCAST_ADDRESS; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DISCOVERY_TIMEOUT_SECONDS; | ||
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.SUPPORTED_THING_TYPES_UIDS; |
There was a problem hiding this comment.
Suggested change
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DISCOVERY_BROADCAST_ADDRESS; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.DISCOVERY_TIMEOUT_SECONDS; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.SUPPORTED_THING_TYPES_UIDS; | |
| import static org.openhab.binding.emotiva.internal.EmotivaBindingConstants.* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Emotiva Audio Corporation AV processors based on the Emotiva Network Remote Control protocol. Discovery is supported.
Binding has only been tested with an XMC-2, so please test and give feedback for other devices.
Has support for all Emotiva notification types in version 2.0 and 3.0 of the protocol, and adds support for almost all commands, has support for Zone 2 controls, browsing and controlling the menu and using the radio tuner.