[iotawatt] Initial contribution #16491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRosenb
changed the title
jlaur
added
the
new binding
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
PRosenb
force-pushed
the
NewBindingIoTaWatt
branch
2 times, most recently
from
4bc5416
to
17eb8d7
Compare
PRosenb
changed the title
lsiepel
requested changes
May 5, 2024
There was a problem hiding this comment.
Thansk for this contribution. In general it seems already solid. Besides the minor comments, i guess there are two areas that i have questions about:
- exception handling / thing status details, see comments.
- thing-types. I see several power/energy rel;ated channels that have diffent quantitytypes declared compare to others bindings that have the same channels. Please double check.
| public IoTaWattHandlerFactory() { | ||
| this.insecureClient = new HttpClient(new SslContextFactory.Client(true)); | ||
| try { | ||
| this.insecureClient.start(); |
There was a problem hiding this comment.
As you manually create and start the client. You should also stop and dispose it in this class to prevent any leaks.
...ding.iotawatt/src/main/java/org/openhab/binding/iotawatt/internal/client/IoTaWattClient.java
Outdated
Show resolved
Hide resolved
...ding.iotawatt/src/main/java/org/openhab/binding/iotawatt/internal/client/IoTaWattClient.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.iotawatt/src/main/resources/OH-INF/addon/addon.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.iotawatt/src/main/resources/OH-INF/i18n/iotawatt.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.iotawatt/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.iotawatt/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.iotawatt/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
PRosenb
force-pushed
the
NewBindingIoTaWatt
branch
from
1e99230
to
2f66691
Compare
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Pete <8108165+PRosenb@users.noreply.github.com>
…/binding/iotawatt/internal/handler/IoTaWattHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Pete <8108165+PRosenb@users.noreply.github.com>
…/binding/iotawatt/internal/handler/IoTaWattHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Pete <8108165+PRosenb@users.noreply.github.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
…/thing/thing-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Pete <8108165+PRosenb@users.noreply.github.com>
…/thing/thing-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Pete <8108165+PRosenb@users.noreply.github.com>
…/thing/thing-types.xml Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Pete <8108165+PRosenb@users.noreply.github.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
PRosenb
force-pushed
the
NewBindingIoTaWatt
branch
from
2f66691
to
89bfd10
Compare
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
PRosenb
force-pushed
the
NewBindingIoTaWatt
branch
from
a03441a
to
b7a6564
Compare
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Signed-off-by: Peter Rosenberg <prosenb.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new binding for IoTaWatt, an open source power measuring device.
The first version aims to get feedback from the community and provide initial, basic functionality to measure power consumption.
Limitations of this version:
Inputchannels with select valuesShort discussion about the topic: Forum thread IoTaWatt
Any kinds of feedback is welcome, thank you.
Snapshot Download