Improve handling of interrupted request by alllowing retries

Rebased Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: gael@lhopital.org <gael@lhopital.org>
openhab · Mar 25, 2024 · f7f7ee4 · f7f7ee4
1 parent 5f29f9f
commit f7f7ee4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/....netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/ApiBridgeHandler.java b/....netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/ApiBridgeHandler.java
@@ -359,10 +359,6 @@ public synchronized <T> T executeUri(URI uri, HttpMethod method, Class<T> clazz,
                         "@text/maximum-usage-reached [ \"%d\" ]".formatted(API_LIMIT_INTERVAL_S), null, null);
             }
             throw e;
-            // } catch (InterruptedException e) {
-            // Thread.currentThread().interrupt();
-            // updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, e.getMessage());
-            // throw new NetatmoException("Request interrupted");
         } catch (InterruptedException | TimeoutException | ExecutionException e) {
             if (retryCount > 0) {
                 logger.debug("Request error, retry counter: {}", retryCount);

diff --git a/.../main/java/org/openhab/binding/netatmo/internal/handler/capability/WeatherCapability.java b/.../main/java/org/openhab/binding/netatmo/internal/handler/capability/WeatherCapability.java
@@ -20,6 +20,8 @@
 import org.openhab.binding.netatmo.internal.api.WeatherApi;
 import org.openhab.binding.netatmo.internal.api.dto.NAObject;
 import org.openhab.binding.netatmo.internal.handler.CommonInterface;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * {@link WeatherCapability} give the ability to read weather station API
@@ -29,6 +31,7 @@
  */
 @NonNullByDefault
 public class WeatherCapability extends CacheWeatherCapability {
+    private final Logger logger = LoggerFactory.getLogger(WeatherCapability.class);
 
     public WeatherCapability(CommonInterface handler) {
         super(handler, Duration.ofSeconds(2));