Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : use rpc to complete the call #1312

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pizihao
Copy link
Collaborator

@pizihao pizihao commented May 20, 2023

Changes proposed in this pull request:

  • add rpc call switch
  • if rpc is enabled,, the client binds additional ports
  • if rpc is enabled,, the server calls the client through rpc
  • if rpc is enabled, modify the called url and adjust the called port number
  • modify the previous call logic to be compatible with the old version
  • adjust all input parameters and return values to be serializable

If rpc is not enabled, the original logic will not be affected

Check mailbox configuration when submitting. Contributor Guide

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.27 ⚠️

Comparison is base (630e840) 28.75% compared to head (857da5d) 28.49%.

❗ Current head 857da5d differs from pull request most recent head 5ecb592. Consider uploading reports for the commit 5ecb592 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1312      +/-   ##
=============================================
- Coverage      28.75%   28.49%   -0.27%     
- Complexity       729      730       +1     
=============================================
  Files            259      259              
  Lines           5829     5886      +57     
  Branches         549      553       +4     
=============================================
+ Hits            1676     1677       +1     
- Misses          3997     4053      +56     
  Partials         156      156              
Impacted Files Coverage Δ
...ain/java/cn/hippo4j/common/model/InstanceInfo.java 0.00% <ø> (ø)
.../src/main/java/cn/hippo4j/common/model/Result.java 0.00% <0.00%> (ø)
...ppo4j/config/service/ThreadPoolAdapterService.java 0.00% <0.00%> (ø)
.../impl/AbstractConfigModificationVerifyService.java 0.00% <0.00%> (ø)
...ThreadPoolConfigModificationVerifyServiceImpl.java 0.00% <ø> (ø)
...ThreadPoolConfigModificationVerifyServiceImpl.java 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant