Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor 1171: optimize @Deprecated coreSize and maxSize #1219

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jjiey
Copy link
Contributor

@jjiey jjiey commented May 4, 2023

Fixes #1171

Changes proposed in this pull request:

Check mailbox configuration when submitting. Contributor Guide

  • Fix all ThreadPoolParameterInfo.java @deprecated related calls
  • Modify property names and related calls
    • ThreadPoolBaseInfo.java / ThreadPoolAdapterState.java / GlobalRemotePoolInfo.java: coreSize => corePoolSize
    • ThreadPoolBaseInfo.java / ThreadPoolAdapterState.java: maximumSize => maximumPoolSize
    • GlobalRemotePoolInfo.java: maxSize => maximumPoolSize

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (9a1089f) 28.46% compared to head (e24c0e9) 28.46%.

❗ Current head e24c0e9 differs from pull request most recent head a066e01. Consider uploading reports for the commit a066e01 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1219   +/-   ##
==========================================
  Coverage      28.46%   28.46%           
  Complexity       730      730           
==========================================
  Files            257      257           
  Lines           5887     5887           
  Branches         551      551           
==========================================
  Hits            1676     1676           
  Misses          4059     4059           
  Partials         152      152           
Impacted Files Coverage Δ
.../cn/hippo4j/common/model/GlobalRemotePoolInfo.java 0.00% <ø> (ø)
...core/executor/state/AbstractThreadPoolRuntime.java 0.00% <0.00%> (ø)
...in/java/cn/hippo4j/common/toolkit/ContentUtil.java 96.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@magestacks
Copy link
Member

The modification scope of this PR is too large, especially the change of cn.hippo4j.common.model.ThreadPoolParameterInfo, which will cause Hippo4j to fail to upgrade.

@magestacks
Copy link
Member

It is recommended to sort out the range of changes under different models, and make modifications after evaluation.

@iwangjie
Copy link
Member

iwangjie commented Jul 3, 2023

Hi. Is it convenient to split the changes to re-examine the code? We need to think more about compatibility and stability. tks!

Copy link
Member

@weihubeats weihubeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict resolution, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize calls related to coreSize and maxSize identified by @Deprecated in code.
4 participants