Implement plugin uninstall mechanism + adding a pair of metadata details #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for f8886b4: arm64-android |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| disableAppPlugin( uuid ); | ||
|
|
||
| QFileInfo fi( mAvailableAppPlugins[uuid].path() ); |
There was a problem hiding this comment.
warning: variable 'fi' of type 'QFileInfo' can be declared 'const' [misc-const-correctness]
Suggested change
| QFileInfo fi( mAvailableAppPlugins[uuid].path() ); | |
| QFileInfo const fi( mAvailableAppPlugins[uuid].path() ); |
| { | ||
| disableAppPlugin( uuid ); | ||
|
|
||
| QFileInfo fi( mAvailableAppPlugins[uuid].path() ); |
There was a problem hiding this comment.
warning: variable name 'fi' is too short, expected at least 3 characters [readability-identifier-length]
QFileInfo fi( mAvailableAppPlugins[uuid].path() );
^|
|
||
| public: | ||
| PluginInformation( const QString &uuid = QString(), const QString &name = QString(), const QString &description = QString(), const QString &author = QString(), const QString &icon = QString(), const QString &path = QString() ) | ||
| PluginInformation( const QString &uuid = QString(), const QString &name = QString(), const QString &description = QString(), const QString &author = QString(), const QString &homepage = QString(), const QString &icon = QString(), const QString &version = QString(), const QString &path = QString() ) |
There was a problem hiding this comment.
warning: 8 adjacent parameters of 'PluginInformation' of similar type ('const QString &') are easily swapped by mistake [bugprone-easily-swappable-parameters]
PluginInformation( const QString &uuid = QString(), const QString &name = QString(), const QString &description = QString(), const QString &author = QString(), const QString &homepage = QString(), const QString &icon = QString(), const QString &version = QString(), const QString &path = QString() )
^Additional context
src/core/pluginmanager.h:35: the first parameter in the range is 'uuid'
PluginInformation( const QString &uuid = QString(), const QString &name = QString(), const QString &description = QString(), const QString &author = QString(), const QString &homepage = QString(), const QString &icon = QString(), const QString &version = QString(), const QString &path = QString() )
^src/core/pluginmanager.h:35: the last parameter in the range is 'path'
PluginInformation( const QString &uuid = QString(), const QString &name = QString(), const QString &description = QString(), const QString &author = QString(), const QString &homepage = QString(), const QString &icon = QString(), const QString &version = QString(), const QString &path = QString() )
^
domi4484
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last bits, I consider the framework done after this.
An uninstall mechanism is now in place for app plugins so people can easily uninstall plugins (instead of knowing where they need to go in their device's storage). In addition, a version metadata detail has been added so authors and users can better debug issues. An homepage metadata detail was also added.
Screenshot:
