Value map combobox filter #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for e9d6732: arm64-android |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nirvn
reviewed
Apr 20, 2024
| } | ||
| } | ||
|
|
||
| Popup { |
There was a problem hiding this comment.
There's a lot of code duplication between that and the relation combobox. Could we try and generalize that into a reusable item for both the RelationCombobox and this value map editor widget?
There was a problem hiding this comment.
Yes I'll look how far is feasible. I was scared about breaking something
There was a problem hiding this comment.
@domi4484 , shall we merge this PR now, and you can try to de-duplication code in a follow up PR?
There was a problem hiding this comment.
@domi4484 , oh actually im this will need a rebase. PageHeader is no more, say hello to QfPageHeader :)
nirvn
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make value map widget searchable
Screen_Recording_20240419_071603.mp4