Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description of the new fucntionality of erase tool #449

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Apr 19, 2024

This adds a new erase tool for lines and polygons.

opengisch/QField#4584

@duke-nyuki
Copy link

@@ -139,6 +139,28 @@ A video demonstration of some editing possibilities:

![type:video](https://player.vimeo.com/video/499564854)<!-- markdown-link-check-disable-line -->

## Erase Tool Functionality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to sit alongside the other tool, have it be a 3rd-level header, and harmonize title with the other tools (i.e. Erase tool, not Erase Tool Functionality).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think if it moved to the same section of reshape tool?

@@ -139,6 +139,28 @@ A video demonstration of some editing possibilities:

![type:video](https://player.vimeo.com/video/499564854)<!-- markdown-link-check-disable-line -->

## Erase Tool Functionality

The erase tool is a new feature introduced in the geometry editor, designed to facilitate the removal of parts of a line or polygon geometry. This tool enables users to efficiently correct paths or polygons directly within the application interface and directly from the field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid referring to features as "newly introduced", this doesn't age well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm completely agree!


The erase tool is a new feature introduced in the geometry editor, designed to facilitate the removal of parts of a line or polygon geometry. This tool enables users to efficiently correct paths or polygons directly within the application interface and directly from the field.

Suppose you have a polygon representing a building footprint, but there's an unwanted protrusion. You can use the erase tool to precisely remove that portion of the polygon, ensuring accuracy in your geometry representation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure I'd call the erase tool "precise" :) The reshape tool is a much more precise tool that'd probably better fit this example.

I'd also note that the erase tool works best with a stylus/pen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think is better to replace the gif, and also add this quote "for more precision utilize with a stylus/pen"?

Comment on lines 148 to 160
### How to Use

1. **Select the Erase Tool**: Locate the erase tool icon in the toolbar of the geometry editor.

2. **Choose Geometry to Erase**: Click on the line or polygon geometry that you want to edit using the erase tool.

3. **Erase Segments or Portions**:

- For lines: Click and drag along the segment(s) you wish to erase.
- For polygons: Click within the area you want to erase, and drag to define the portion to be removed.
4. **Confirm Erase Action**: Once you have selected the desired segments or portions to erase, release the mouse button to confirm the erase action.

5. **Finalize Changes**: Save your changes or continue editing as needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should get rid of this section. We do not go into that much detailing for other tools. I feel the two paragraphs introducing the feature + a screencast should be enough. We already go into more details on how to open the geometry editor toolbox to begin with.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think is better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants