23-019 document update #183

humaidkidwai · 2024-04-24T01:16:17Z

No description provided.

This reverts commit 1d439bc.

… into 23-019

This reverts commit 1d439bc.

hylkevds · 2024-04-24T11:01:58Z

sections/clause_06_overview.adoc

-
-An SensorThings API Server implementation can implement the full OData specification.
-An OData client can access a SensorThings API service.
+The OGC SensorThings API v2 interface is not an OData interface and does not claim to be an OData service. It specifies a subset of the OData interface, and extends it at the same time.


Git works on a per-line-basis, so avoid long lines. Once sentence per line gives the cleanest history and makes diffs easier to read.

hylkevds · 2024-04-24T11:05:06Z

sections/clause_07a_sensing_core_entities.adoc

@@ -37,10 +34,11 @@ image::images/GRP0001.png[Sensing Core, align="center"]
 In this section, we define each entity depicted in <<img-sta-core>> and its relationships with other entities.
 Additionally, we also provide examples to model the entities in different contexts.

-[[thing]]
-==== Thing
+==== Requirement Class: Thing


The [[thing]] anchor allows referencing this section. Not sure if we ever need to though, can always re-add the anchors.

merge issue, will fix. Thanks for pointing!

hylkevds · 2024-04-24T11:08:33Z

sections/clause_07a_sensing_core_entities.adoc

@@ -893,7 +889,7 @@ Each Feature entity SHALL have the mandatory properties and MAY have the optiona
 [%metadata]
 identifier:: {identifier}/req/datamodel/sensing/feature/relations

-Each Feature entity SHALL have the direct relation between a Feature entity and other entity types listed in Table {counter:table-num}.
+Each Thing entity SHALL have the direct relation between a Thing entity and other entity types listed in Table XX.


I'm pretty sure this section is about Feature, not Thing?

Why change the {counter:table-num} to XX?
{counter:table-num} should give the number of the previous table.

looks like a merge issue

hylkevds · 2024-04-24T11:20:43Z

sections/clause_07c_sampling_entities.adoc

@@ -1,3 +1,5 @@
+:sectnums: |,all|


Don't change template things unless absolutely sure about it.

hylkevds · 2024-04-24T11:22:43Z

images/GRP0001.png

If you delete images, make sure they are not used any more!
Currently the document can not be built.

merge issues again :(

sections/clause_07a_sensing_core_entities.adoc

hylkevds · 2024-04-24T11:26:15Z

sections/clause_07d_actuation_entities.adoc

Best not combine renaming with editing. It's not impossible to see what (if anything) was changed in this file.

The file did not have any content though, will try to be careful about it next time

hylkevds · 2024-04-24T11:35:17Z

sections/clause_06_overview.adoc

-Samplings may be generated by a sequence of SamplingProcedures (and vice-versa), however a Sampler must employ a unique SamplingProcedure to maintain unique Sampling-Sampler-SamplingProcedure relationships.
-In scenarios where a Feature is not directly available for Sampling, a PreparationProcedure composed of multiple PreparationSteps may optionally be used to generate a PreparedFeature.
+In order to generate Samplings, a Sampler, that may be any physical device (or even a human being part of a survey campaign), must carefully select a SamplingProcedure.
+A Sampling may be generated by a SamplingProcedure. This SamplingProcedure can be used by multiple Samplers, however a Sampler can not use multiple SamplingProcedures. Hence, any Sampling that is generated by a Sampler is always associated with a unique SamplingProcedure.


One sentence per line please, hard to comment otherwise.

however a Sampler can not use multiple SamplingProcedures

Hmm, that may need fixing. I think some Samplers can implement many SamplingProcedures... However, a Sampling can only be created by a single one.

Yeah, I agree with the Sampler->SamplingProcedure relationship. I was planning to discuss it in the telco today, good that you pointed this one out

hylkevds · 2024-04-24T11:43:42Z

sections/clause_06_overview.adoc

-In scenarios where a Feature is not directly available for Sampling, a PreparationProcedure composed of multiple PreparationSteps may optionally be used to generate a PreparedFeature.
+In order to generate Samplings, a Sampler, that may be any physical device (or even a human being part of a survey campaign), must carefully select a SamplingProcedure.
+A Sampling may be generated by a SamplingProcedure. This SamplingProcedure can be used by multiple Samplers, however a Sampler can not use multiple SamplingProcedures. Hence, any Sampling that is generated by a Sampler is always associated with a unique SamplingProcedure.
+In scenarios where a Feature is not directly available for Sampling, a PreparationProcedure composed of multiple PreparationSteps may optionally be used to generate a PreparedSample (Feature entity).


In scenarios where a Feature is not directly available for Sampling

What does that mean?
From OMS: In addition, various preparation steps may be performed on samples both before and after observations are performed on the sample.

It means when a Feature is basically a prepared Feature (or Sample). For example, in case of water quality monitoring, it is not feasible to have the entire River Feature available to observe, a PreparationProcedure is applied to get a sample of water

No, preparation procedures are not used to create a sample. Sampling procedures create samples. Preparation procedures are applied to samples to prepare them for measuring, or to conserve them like with specimens.

humaidkidwai · 2024-04-24T20:11:09Z

I don't understand why are commits from March 20 included in this PR

hylkevds · 2024-04-25T06:11:35Z

I don't understand why are commits from March 20 included in this PR

Probably because you based this PR on the commits from back then. You need to reset your working copy to the right branch/commit before making a new branch.

hylkevds

There is still this "sync local branch" commit (and 4 others) that should not be there.

hylkevds · 2024-04-26T07:32:53Z

sections/clause_06_overview.adoc


-[[who-should-use]]
-=== Who should use the OGC SensorThings API


That heading should not have been removed.

hylkevds · 2024-04-26T08:01:45Z

There is still this "sync local branch" commit (and 4 others) that should not be there.

I've cherry-picked just the last commit onto the 23-019 branch, into a 23-019_documentation2 branch, you could use that one instead if you want.

humaidkidwai added 5 commits March 20, 2024 01:49

Updated sections 06, 07b, 07c and Images for STA 2.0

1d439bc

Revert "Updated sections 06, 07b, 07c and Images for STA 2.0"

7e8b32b

This reverts commit 1d439bc.

Merge branch '23-019' of https://github.com/opengeospatial/sensorthings…

f2c015d

… into 23-019

Revert "Updated sections 06, 07b, 07c and Images for STA 2.0"

01e8ff4

This reverts commit 1d439bc.

sync local branch

d177392

humaidkidwai requested a review from hylkevds April 24, 2024 01:16

hylkevds requested changes Apr 24, 2024

View reviewed changes

Update Overview, Sensing Core and Actuation

9911352

humaidkidwai force-pushed the 23-019_documentation branch from 4a0f11c to 9911352 Compare April 24, 2024 20:04

hylkevds requested changes Apr 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

23-019 document update #183

23-019 document update #183

humaidkidwai commented Apr 24, 2024

hylkevds Apr 24, 2024

hylkevds Apr 24, 2024

humaidkidwai Apr 24, 2024

hylkevds Apr 24, 2024

humaidkidwai Apr 24, 2024

hylkevds Apr 24, 2024

humaidkidwai Apr 24, 2024

hylkevds Apr 24, 2024

humaidkidwai Apr 24, 2024

hylkevds Apr 24, 2024

humaidkidwai Apr 24, 2024

hylkevds Apr 24, 2024

humaidkidwai Apr 24, 2024

hylkevds Apr 24, 2024

humaidkidwai Apr 24, 2024

hylkevds Apr 25, 2024

humaidkidwai commented Apr 24, 2024

hylkevds commented Apr 25, 2024

hylkevds left a comment

hylkevds Apr 26, 2024

hylkevds commented Apr 26, 2024


		[[who-should-use]]
		=== Who should use the OGC SensorThings API

23-019 document update #183

Are you sure you want to change the base?

23-019 document update #183

Conversation

humaidkidwai commented Apr 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

humaidkidwai commented Apr 24, 2024

hylkevds commented Apr 25, 2024

hylkevds left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hylkevds commented Apr 26, 2024