✨(frontend) Filter video views #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
reviewed
Jun 13, 2023
lebaudantoine
force-pushed
the
feature/date-picker
branch
from
5f19e58
to
9ee1d89
Compare
lebaudantoine
force-pushed
the
feature/date-picker
branch
from
9ee1d89
to
80303b2
Compare
New release of Cunningham offers components such as DatePicker or DateRangePicker, which are necessary to filter our data.
Generated design tokens were breaking the default Roboto font. These new values are copied from the Cunningham demo app.
lebaudantoine
force-pushed
the
feature/date-picker
branch
from
b51fa43
to
d464a2d
Compare
Introduce a new component responsible to inject all the required providers to make warren web app works.
To manage and share filters' state across multiple components, we adopted a basic workaround by using React context. This approach allows us to store and provide the filters state efficiently to all subscribers in our app.
Factorize Axios instanciation and configuration in a dedicated file, along the react-query. We would avoid dupplicating these lines.
lebaudantoine
force-pushed
the
feature/date-picker
branch
from
d464a2d
to
cba757e
Compare
This component would be responsible to render the filters bar in our dashboarding web app.
Component is now subscribing to filters state. Note: Time management in the current version of the frontend and the API is still bulky. A lot of work need to be done.
lebaudantoine
force-pushed
the
feature/date-picker
branch
from
cba757e
to
e0e2cb5
Compare
lebaudantoine
changed the title
jmaupetit
reviewed
Jul 21, 2023
jmaupetit
approved these changes
Jul 21, 2023
lebaudantoine
force-pushed
the
feature/date-picker
branch
from
e7fa0e5
to
71ef076
Compare
Documentation misled me to think only UTC timezone was allowed. This add an example of handling queries in a non-UTC timezone using an ISO format.
lebaudantoine
force-pushed
the
feature/date-picker
branch
from
71ef076
to
f07415b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement the initial filtering tools for our web dashboard app
Proposal
This PR introduces a shared filters state that updates the video views chart component.
Current filters are:
Some
echartsanimation might feel buggy, we are constrained by this issue. Plus, recent API refactoring by @cyrillay modified the way we handle null-view day. It should be fixed in the API soon.Subsequent PRs will address the refactoring of the UI packages to further enhance the project's structure and maintainability.
Note, that
DateRangePickergonna evolved when this PR is merged.Urgent: We need to discuss time management in Warren (both frontend and backend) as soon as possible. This crucial conversation will help ensure a successful implementation.