New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️(backend) upgrade to Django 4.x (4.0, 4.1, <5) #2390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
2 times, most recently
from
May 6, 2024 15:23
2d32cb7
to
7e6c14f
Compare
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
3 times, most recently
from
May 7, 2024 10:18
aedaaed
to
24256ef
Compare
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
10 times, most recently
from
May 13, 2024 11:34
857ec2b
to
7222768
Compare
jonathanreveille
changed the title
⬆️(backend) upgrade to Django 4.x (4.0, 4.1, 4.2)
⬆️(backend) upgrade to Django 4.x (4.0, 4.1, <5)
May 13, 2024
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
3 times, most recently
from
May 13, 2024 13:58
87acfc9
to
50ac3f9
Compare
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
from
May 13, 2024 14:08
50ac3f9
to
3866493
Compare
jbpenrath
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a custom linter in the backend I think ^^
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
from
May 13, 2024 15:10
3866493
to
22bf379
Compare
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
from
May 13, 2024 15:28
22bf379
to
1ef8a63
Compare
kernicPanel
approved these changes
May 13, 2024
lunika
reviewed
May 14, 2024
wilbrdt
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
lunika
approved these changes
May 14, 2024
wilbrdt
approved these changes
May 14, 2024
lunika
approved these changes
May 14, 2024
jbpenrath
approved these changes
May 14, 2024
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
from
May 14, 2024 14:14
b3272d1
to
bb9829e
Compare
Since Django 4.0, the use of `pytz` is deprecated within Django and is replaced by `zoneinfo` to use `datetime.timezone` instead. We drop the support of postgres version less than 12. We have also updated the template tags `{% ifequal %}` in favor of `{% if %}` template tag. The setting configuration `USE_L10N` is deprecated in the settings if the value is `True`.
Some admin view tests required some adjustments. The count of strings in the admin template of Django has changed from version 4 to 4.1 of Django.
Since Django 4.2, we have dropped the support of mysql < 8. We have dropped the job on circleci for `test-back-mysql-5`. We have updated in settings `STORAGES` configuration for staticfiles and default file storage declaration.
jonathanreveille
force-pushed
the
upgrade_django_version_dependency
branch
from
May 14, 2024 14:29
bb9829e
to
2f5902f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
From Django version 3.2.25 to 4.0 :
The project was using Django 3.2.25, it now uses Django 4.0, this involved :
pytz
library todatetime.timezone
instead.{% ifequal %}
in favor of{% if %}
.USE_L1ON
is deprecated in settings if value isTrue
From Django 4.0 to 4.1 :
From Django 4.1 to 4.2:
Proposal