✨(frontend) refetch user profile after edition #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpenrath
reviewed
Apr 22, 2024
rlecellier
force-pushed
the
rlecellier/refetch_profile_information_after_edit
branch
14 times, most recently
from
7b0ffa1
to
8ff9776
Compare
jbpenrath
reviewed
Apr 25, 2024
rlecellier
force-pushed
the
rlecellier/refetch_profile_information_after_edit
branch
from
8ff9776
to
d98783d
Compare
rlecellier
force-pushed
the
rlecellier/refetch_profile_information_after_edit
branch
2 times, most recently
from
b69a3b5
to
90e5476
Compare
jbpenrath
reviewed
May 15, 2024
src/frontend/js/pages/DashboardCreditCardsManagement/DashboardEditCreditCard.spec.tsx
Show resolved
Hide resolved
rlecellier
force-pushed
the
rlecellier/refetch_profile_information_after_edit
branch
2 times, most recently
from
d2a017e
to
7cafd82
Compare
jbpenrath
approved these changes
May 16, 2024
prefere using userEvent as act+fireEvent.
When a user go on OpenEdx profile form, it needs to see its data up to date when coming back. The click happend now in the same tab.
rlecellier
force-pushed
the
rlecellier/refetch_profile_information_after_edit
branch
from
7cafd82
to
e655159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On click on modify profile, we open a new window in OpenEdx profile page.
When modification are done, we would like to refresh informations display on this page.
This onWindowFocus event will be trigger the first time the user came back from OpenEdx profile page to refresh the informations. /!\ It's not perfect as it'll not work it he go and back from one tab to the other.