Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️(frontend) Refactor DashboardItemOrder #2206

Closed
wants to merge 2 commits into from

Conversation

rlecellier
Copy link
Collaborator

@rlecellier rlecellier commented Dec 21, 2023

Purpose

issue: #2159

  • move DashboardItemOrder as sub-component of order's detail page: OrderDetails
  • create a sub-component of order's listing page: OrderListItem
  • extract order listing test from OrderDetails to pages/DashbaordCourses and pages/DashbaordCourses/components/OrderListItem
  • extract order's details test from OrderDetails to pages/DashboardOrderLayout and pages/DashboardOrderLayout/components/OrderDetails
  • factorize reused part of OrderListItem and OrderDetails into DashboardItem

@rlecellier rlecellier force-pushed the rlecellier/split_dashboard_item_order branch from b13801a to e11a982 Compare December 21, 2023 16:39
@rlecellier rlecellier changed the title Rlecellier/split dashboard item order ♻️(frontend) Refactor DashboardItemOrder Dec 21, 2023
rename to OrderStatus to match other status components we've like
Certificate and Contract
moved it to component because theses status messages can be used outside
of this component.
DashboardItemOrder is the content of order's detail page.
Let's move it where it belong.
@rlecellier rlecellier force-pushed the rlecellier/split_dashboard_item_order branch from e11a982 to 4d64661 Compare January 3, 2024 09:17
@rlecellier
Copy link
Collaborator Author

Too old, not clean enough

@rlecellier rlecellier closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant