Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1826 Changed text color according to mode #1845

Merged
merged 2 commits into from
May 14, 2022

Conversation

vik4114
Copy link
Contributor

@vik4114 vik4114 commented May 14, 2022

@vik4114 vik4114 requested a review from a team as a code owner May 14, 2022 19:07
@codecov-commenter
Copy link

Codecov Report

Merging #1845 (40e0c42) into develop (2ea0da3) will decrease coverage by 1.77%.
The diff coverage is 9.64%.

@@            Coverage Diff             @@
##           develop   #1845      +/-   ##
==========================================
- Coverage     8.86%   7.09%   -1.78%     
==========================================
  Files          161     174      +13     
  Lines         6623    7868    +1245     
==========================================
- Hits           587     558      -29     
- Misses        6036    7310    +1274     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...th_app/lib/cards/data_cards/image_upload_card.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/cards/data_cards/score_card.dart 4.54% <0.00%> (-0.22%) ⬇️
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_element_card.dart 0.00% <0.00%> (ø)
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b8f97a...40e0c42. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@M123-dev M123-dev merged commit 04d5b42 into openfoodfacts:develop May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button to finish picture cropping isn't visible (dark mode issue)
3 participants