feat: Pull MongoDB and Redis from shared-services repo #10266
+164
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
github-actions
bot
added
MongoDB
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
alexgarel
reviewed
May 20, 2024
There was a problem hiding this comment.
I am a bit sceptical about duplicating so much to avoid pulling deps.
Why not have instead "test_deps" and "deps" in the Makefile to avoid pulling too much, still keeping things DRY and consistent ?
There was a problem hiding this comment.
Hi @alexgarel , I've tweaked it so the deps are cloned for tests but not run so that we can reference the docker yml in the test targets. Let me know what you think. Note there are changes to shared-services that go with this, but clone deps should do a pull anyway
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Create a test.yml for integration tests but otherwise MongoDB and Redis come from the shared-services repo.
https://github.com/openfoodfacts/openfoodfacts-shared-services