Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: packaging codes add Austria #10264

Merged
merged 3 commits into from May 15, 2024
Merged

Conversation

benbenben2
Copy link
Collaborator

What

packaging codes: add Austria

Screenshot

Screenshot_20240510_141313

Related issue(s) and discussion

Part of #338

More details based on previous work (#8921, #8958):

  • lib/ProductOpener/Display.pm
    add description (name, street, city) based on columns in the file or hardcoded
  • lib/ProductOpener/PackagerCodes.pm
    add country and suffix of the code
  • scripts/update_packager_codes.pl
    add code formatting ('country' 'code' 'suffix', for example if code does not already contain 'country' or 'suffix')
    add the column name for the $code variable
  • packager-codes/
    add the csv file
  • scripts/packager-codes/
    add your script (remove api keys if any)
  • update sto files
docker exec -it po_off-backend-1 bash
./scripts/update_packager_codes.pl

@benbenben2 benbenben2 added 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- Austria labels May 10, 2024
@benbenben2 benbenben2 self-assigned this May 10, 2024
@benbenben2 benbenben2 requested a review from a team as a code owner May 10, 2024 12:59
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great 😃👍

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit eedfe5c into main May 15, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the packaging_add_austria branch May 15, 2024 08:13
john-gom pushed a commit that referenced this pull request May 24, 2024
packaging codes: add Austria
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Austria Display 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near-
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load packaging codes for Austria
3 participants