Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: translate categories in Croatian #10259

Merged
merged 8 commits into from May 17, 2024

Conversation

benbenben2
Copy link
Collaborator

What

translate categories in Croatian

Related issue(s) and discussion

  • Fixes #-

@benbenben2 benbenben2 self-assigned this May 9, 2024
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels May 9, 2024
@teolemon teolemon added the 🇭🇷 Croatia https://hr.openfoodfacts.org/ label May 13, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new categories are in lowercase, is that intended?
Just curious, did you use some kind of automated script / AI to translate and add the categories?

@benbenben2
Copy link
Collaborator Author

The new categories are in lowercase, is that intended? Just curious, did you use some kind of automated script / AI to translate and add the categories?

Yes, a script was used for that.

I updated to start by upper case for first character

@benbenben2 benbenben2 requested a review from a team as a code owner May 16, 2024 21:37
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@benbenben2
Copy link
Collaborator Author

I just tried to update integration test manually because I could not do it, nor run tests inside the container:

docker exec -it po_off-backend-1 bash
perl tests/integration/web_html.t

Can't locate Test/File/Contents.pm in aINC (you may need to install the Test::File::Contents module)
(can't install the package, Permission denied)

Also outside the container:

make test-int test="web_html.t"

OCI runtime exec failed: exec failed: unable to start container process: exec: "yath": executable file not found in $PATH: unknown
make: *** [Makefile:299 : test-int] Erreur 126

@stephanegigandet
Copy link
Contributor

@benbenben2 You may need to run "make dev" again to install the new modules that have been added in recent weeks.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 30ca878 into main May 17, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the taxonomy_translate_categories_in_croatian branch May 17, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🇭🇷 Croatia https://hr.openfoodfacts.org/ 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants