Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Whatsapp channel link (please read question) #10219

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Josckar
Copy link

@Josckar Josckar commented May 3, 2024

What

Added a link to the WhatsApp Channel to site_layout.tt.html to solve the issue

Screenshot

image

Related issue(s) and discussion

Question: where are the icons for /images/icons/dist/, such as in the site layout, stored? At the moment, the line assumes the whatsapp icon will exist in whatever directory it should exist in (it is in neither ./html/images/icons/dist nor [icons][./icons].

@Josckar Josckar requested a review from a team as a code owner May 3, 2024 00:25
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Site layout labels May 3, 2024
@teolemon teolemon changed the title Whatsapp channel link (please read question) feat: Whatsapp channel link (please read question) May 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.68%. Comparing base (dc04d18) to head (185328f).
Report is 286 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10219      +/-   ##
==========================================
+ Coverage   49.54%   49.68%   +0.13%     
==========================================
  Files          67       71       +4     
  Lines       20650    20982     +332     
  Branches     4980     5026      +46     
==========================================
+ Hits        10231    10424     +193     
- Misses       9131     9266     +135     
- Partials     1288     1292       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hangy
Copy link
Member

hangy commented May 5, 2024

Question: where are the icons for /images/icons/dist/, such as in the site layout, stored? At the moment, the line assumes the whatsapp icon will exist in whatever directory it should exist in (it is in neither ./html/images/icons/dist nor [icons][./icons].

The original icons are stored in /icons and copied to /html/images/icons/dist with gulp.

@github-actions github-actions bot added the icons label May 6, 2024
@Josckar
Copy link
Author

Josckar commented May 6, 2024

Thank you!

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons 💥 Merge Conflicts 💥 Merge Conflicts Site layout Social media links Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the link to the Whatsapp channel in social media links
5 participants