Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Product Opener to fetch Redis and MongoDB Dependencies from openfoodfacts-shared-services repo #10265

Open
3 of 8 tasks
john-gom opened this issue May 10, 2024 · 0 comments · May be fixed by #10266
Open
3 of 8 tasks
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@john-gom
Copy link
Contributor

john-gom commented May 10, 2024

Description

We want to move Redis and MongoDB into their own repo so that other projects that depend on these, like off-query, can just pull in these dependencies without needing the whole of Product Opener.

Acceptance criteria

Can develop on a related project, like off-query, without running ProductOpener locally.

What would a demo look like

With a clean directory tree, clone off-query and make deps to show that MongoDB and Redis are available.

Notes

At the moment MongoDB exposes the html/data directory for imports and its data/db directory for running scripts. It is proposed that the scripts that PO needs should now run in Perl (create_mongodb_indexes) and that the full product import should be moved into the shared_services repo.

Should we also make a test SMTP server a shared service?

Tasks

  • Create shared-services repo with MongoDB and Redis containers
  • Update PO create_mongodb_indexes to run without direct access to a MongoDB volume
  • Move the import_prod_data target to shared_services (PO version can call out to this)
  • Remove MongoDB and Redis container definitions from PO (except for when running integration tests)
  • Move GitHub action to deploy MongoDB from PO to shared_services
  • Update off-query to use shared_services for MongDB and Redis
  • Update off-auth to use shared_services for Redis
  • Add branch protection to openfoodfacts-shared-services
@john-gom john-gom self-assigned this May 10, 2024
@teolemon teolemon added the dependencies Pull requests that update a dependency file label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: To discuss and validate
Development

Successfully merging a pull request may close this issue.

2 participants