Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 890 - new method getLocalizedCountryNames #904

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: 890 - new method getLocalizedCountryNames #904

wants to merge 2 commits into from

Conversation

monsieurtanuki
Copy link
Contributor

What

  • New method getLocalizedCountryNames, that takes localized names of countries from the OFF server.
  • Helpful specifically outside android and iOS - in both platforms country names can be taken from the device.
  • Probably helpful for android and iOS too - in order to have more control on country names and to avoid weird cases like "Soviet Union" (cf. Add a complete list of localizedCountries smooth-app#4921)

Fixes bug(s)

Part of

Impacted files

  • api_get_product_test.dart: test for new method getLocalizedCountryNames
  • open_food_api_client.dart: new method getLocalizedCountryNames

@monsieurtanuki
feat: 890 - new method getLocalizedCountryNames
b7b0694 
Impacted files:
* `api_get_product_test.dart`: test for new method `getLocalizedCountryNames`
* `open_food_api_client.dart`: new method `getLocalizedCountryNames`
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner April 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon Awaiting requested review from teolemon

At least 1 approving review is required to merge this pull request.

Assignees

@monsieurtanuki monsieurtanuki

Labels
country
Projects
Dart package - Support for new APIs and issues
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get a localized list of countries
2 participants
@monsieurtanuki @teolemon