fix: ImageHelper - new methods with ImageSize parameters + minor fix #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted file: * `ImageHelper.dart`: added flexibility and `ImageSize` parametered methods; fixed a minor bug (trailing slash)
|
Would it be possible to shorten function naming a bit. Some are getting overly verbose imho. I suggest making |
Impacted file: * `ImageHelper.dart`: added optional parameters instead of methods.
Sounds reasonable. |
M123-dev
approved these changes
Oct 11, 2022
| @@ -27,23 +27,31 @@ class ImageHelper { | |||
| } | |||
| } | |||
|
|
|||
| /// Returns the product image full url, or null if [barcode] is null | |||
| /// Returns the [image] full url - for a specific [imageSize] if needed. | |||
There was a problem hiding this comment.
Suggested change
| /// Returns the [image] full url - for a specific [imageSize] if needed. | |
| /// Returns the image full url as [String] - for a specific [imageSize] if needed. |
|
|
||
| /// Returns the product image filename | ||
| /// Returns the [image] filename - for a specific [imageSize] if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted file:
ImageHelper.dart: added flexibility andImageSizeparametered methods; fixed a minor bug (trailing slash)What
ImageHelperPart of