Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #304 - new method setProductImageAngle #309

Merged
merged 3 commits into from Dec 9, 2021
Merged

feat: #304 - new method setProductImageAngle #309

merged 3 commits into from Dec 9, 2021

Commits on Dec 5, 2021

  1. feat: openfoodfacts#304 - new method setProductImageAngle 

    Deleted file:
* `corn_da.jpg`

Impacted files:
* `api_addProductImage_test.dart`: added a test for `OpenFoodAPIClient.setProductImageAngle`; removed a duplicate test
* `JsonHelper.dart`: decoded new fields `imgid` and `angle` for product `'images`''
* `openfoodfacts.dart`: new method `setProductImageAngle`
* `ProductImage.dart`: added `enum ImageAngle`; added `imgid` and `angle` to `ProductImage`
* `UriHelper.dart`: unrelated refactoring
    @monsieurtanuki
    monsieurtanuki committed Dec 5, 2021
    Copy the full SHA
    10177f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. feat: openfoodfacts#305 - new method setProductImageCrop 

    Impacted files:
* `api_addProductImage_test.dart`: added a test for `OpenFoodAPIClient.setProductImageCrop`; minor refactoring
* `ImageHelper.dart`: added methods `getProductImageRootUrl` and `getProductImageFilename`; minor refactoring
* `JsonHelper.dart`: populated crop fields of `ProductImage` for product `'images'`; minor refactoring
* `openfoodfacts.dart`: added method `setProductImageCrop`; minor refactoring
* `ProductHelper.dart`: minor refactoring
* `ProductImage.dart`: added crop fields `coordinatesImageSize`, `x1`, `y1`, `x2` and `y2` to `ProductImage`
    @monsieurtanuki
    monsieurtanuki committed Dec 7, 2021
    Copy the full SHA
    a033813 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. feat: openfoodfacts#304 - added comments after code review 

    Impacted file:
* `ProductImage.dart`
    @monsieurtanuki
    monsieurtanuki committed Dec 9, 2021
    Copy the full SHA
    a70e6b9 View commit details
    Browse the repository at this point in the history