New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update to latest KnowledgePanel API changes #294
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
cf826ac
Merge pull request #4 from openfoodfacts/master
jasmeet0817 b637a01
Updates to KnowledgePanel json object to comply to latest BE changes
11d8e9a
Merge branch 'openfoodfacts:master' into master
jasmeet0817 3a9186a
Changes to KnowledgePanel to comply to BE
5e9b5ed
Merge branch 'openfoodfacts:master' into master
jasmeet0817 835a8bb
Changes to KnowledgePanel to comply to BE
db1d0ee
Update tests
8e57e32
format
cfbc0dc
add a comment
79e85da
update comment
c18b3dc
Add Evaluation
fd02795
Fix tests
f80c696
Add to KnowledgePanels
bb1ce13
Merge branch 'openfoodfacts:master' into master
jasmeet0817 424d2fc
Merge remote-tracking branch 'origin'
508d27c
Merge branch 'openfoodfacts:master' into master
jasmeet0817 65dba15
Remove from KnowledgePanel and add a KnowledgePanelGroupElement to p…
b98839e
Remove from KnowledgePanel and add a KnowledgePanelGroupElement to p…
45bcdcd
Remove unnecessary comments
d7aaf85
Fix tests
ed4466d
Fix build
a8c888c
Add a new KnowledgePanel type
d596e48
Add a new KnowledgePanel type
a0eae4a
Make elements nullable
5d1538d
Make elements nullable
c27309f
Cosmetic change
2724a34
Remove print
ae2399c
Merge branch 'openfoodfacts:master' into master
jasmeet0817 3158b3b
Prepare release of version 1.3.7
c22e5b3
Merge branch 'openfoodfacts:master' into master
jasmeet0817 f650d9a
Column should not have list<String> text and type
5a716bf
Column should not have list<String> text and type
d6ba226
Column should not have list<String> text and type
6b82401
Changes to KnowledgePanel API to comply to the server response
121b1ed
Merge branch 'openfoodfacts:master' into master
jasmeet0817 8805a50
Merge remote-tracking branch 'origin'
8ba12e1
Changes to KnowledgePanel API to comply to the server response
1e7e113
Fix tests
650045b
Merge branch 'openfoodfacts:master' into master
jasmeet0817 2eb95a3
Update KP
f4664e3
Merge branch 'master' of https://github.com/openfoodfacts/openfoodfac…
3e31210
Update KP
abd8663
Fix KP
b53b430
Fix KP
11e100d
Fix KP
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no @JsonValue('unknown') ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more value is "neutral" if I remember correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right: environment/packaging_recycling.tt.json: "evaluation": "neutral",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between "average" and "neutral"? Can't we collapse them into one ?
Unknown: the object gets a value of enum type UNKNOWN when the json parser encounters a value from the server that isn't mappable to anything else in this enum (specifically if server responds with something other than Good, bad, average, the variable is assigned UNKNOWN).