Add repository to work with camera prefs #4230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaiTon
reviewed
Sep 19, 2021
| @@ -223,7 +225,7 @@ class ContinuousScanActivity : BaseActivity(), IProductView { | |||
| .apply { setGravity(CENTER, 0, 0) } | |||
| .show() | |||
|
|
|||
| Log.w(LOG_TAG, err.message, err) | |||
There was a problem hiding this comment.
because LOG_TAG uses explicit unwrap here, I'm trying to avoid using !! everywhere just because it requires always think "is it safe to use !! here or not? does it crash on production?"
and we use this tag only in one place so I changed it to a simple string
naivekook
force-pushed
the
vt/extract-camera-prefs
branch
from
73499cb
to
94de46d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
merged within #4236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract all logic related to changing camera prefs to a separate repository. This is needed to use the same settings for ContinuousScan and SimpleScan features.
Related issues