build: bump compileSdk to 31 to support newer androidx libraries

fix: type errors with new deps
openfoodfacts · Dec 18, 2021 · d8f8a30 · d8f8a30
1 parent e10bbd7
commit d8f8a30
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -194,7 +194,7 @@ dependencies {
 }
 
 android {
-    compileSdk = 30
+    compileSdk = 31
 
     testBuildType = obtainTestBuildType()
 

diff --git a/...in/java/openfoodfacts/github/scrachx/openfood/features/productlist/ProductListActivity.kt b/...in/java/openfoodfacts/github/scrachx/openfood/features/productlist/ProductListActivity.kt
@@ -343,7 +343,7 @@ class ProductListActivity : BaseActivity(), SwipeController.Actions {
 
     @RequiresApi(Build.VERSION_CODES.KITKAT)
     val fileWriterLauncher = registerForActivityResult(CreateCSVContract())
-    { writeListToFile(this, productList, it) }
+    { uri -> uri?.let { writeListToFile(this, productList, it) } }
 
     private fun exportAsCSV() {
         Toast.makeText(this, R.string.txt_exporting_your_listed_products, Toast.LENGTH_LONG).show()

diff --git a/...a/openfoodfacts/github/scrachx/openfood/features/simplescan/SimpleScanActivityContract.kt b/...a/openfoodfacts/github/scrachx/openfood/features/simplescan/SimpleScanActivityContract.kt
@@ -5,22 +5,24 @@ import android.content.Context
 import android.content.Intent
 import androidx.activity.result.contract.ActivityResultContract
 
+/**
+ * Returns a string containing the product barcode.
+ */
 class SimpleScanActivityContract : ActivityResultContract<Unit, String?>() {
 
     companion object {
         const val KEY_SCANNED_BARCODE = "scanned_barcode"
     }
 
-    override fun createIntent(context: Context, input: Unit?): Intent {
+    override fun createIntent(context: Context, input: Unit): Intent {
         return Intent(context, SimpleScanActivity::class.java)
     }
 
     override fun parseResult(resultCode: Int, intent: Intent?): String? {
         val bundle = intent?.extras ?: return null
-        return if (resultCode == Activity.RESULT_OK && bundle.containsKey(KEY_SCANNED_BARCODE)) {
-            bundle.getString(KEY_SCANNED_BARCODE, null)
-        } else {
-            null
+        if (resultCode == Activity.RESULT_OK && bundle.containsKey(KEY_SCANNED_BARCODE)) {
+            return bundle.getString(KEY_SCANNED_BARCODE, null)
         }
+        return null
     }
 }