feat: add column limits on the main pages and change the color scheme #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… priceslist, productlist, search, signin, userdashboard and userlist, and add v-btn to the home buttons
fbtw
changed the title
raphodn
reviewed
Mar 20, 2024
| @@ -12,6 +12,15 @@ | |||
| </v-app> | |||
| </template> | |||
|
|
|||
| <style> | |||
| .v-main{ | |||
There was a problem hiding this comment.
Could you remove all the "style" changes of your PR?
- to avoid mixing column changes and style changes (easier to review)
- the colors are already mostly in line with OFF. see Bring the Header background color in line with the other OFF projects #298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added column limits for lg, md and sm screens on the principal sites home, sign in, search, user dashboard, user list, prices, products and locations
Changed the card buttons into actual v-btn buttons
Changed some colors using the vue's style tags on the header, app.js and footer
Screenshots
Large screen
Medium screen
Small screen
Notes
Colors used:
header #ff8e00
footer #1E1E24
links #309191
background #FFFCF2
Some of the changes look big but are just automatic indention, like in search and sign in