feat: Make sign in button similar to OFF #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
changed the title
raphodn
reviewed
Jan 28, 2024
| @@ -6,14 +6,12 @@ | |||
| {{ APP_NAME }} | |||
| </v-app-bar-title> | |||
| <template v-slot:append> | |||
| <v-btn v-if="!username" to="/sign-in" icon="mdi-login"></v-btn> | |||
| <v-btn v-if="!username" to="/sign-in" prepend-icon="mdi-account" class="text-none">Sign in</v-btn> | |||
|
I would also either have a different logo or the color of the logo if signed in or signed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #65
I think Pierre got mislead by the sign in icon which is very close to the sign out. I propose To follow OFF behavior: if sign in display the name otherwise display "sign in"
This PR is mostly for me to get familiar back with vue.js If you prefer the previouse behavior no pb