Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the id from en:united-kingdom to en:uk #743

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexfauquette
Copy link
Member

Fix #740

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for warm-cannoli-79bbb2 ready!

Name Link
🔨 Latest commit b4903a8
🔍 Latest deploy log https://app.netlify.com/sites/warm-cannoli-79bbb2/deploys/65462c4838bd9a0009d092e0
😎 Deploy Preview https://deploy-preview-743--warm-cannoli-79bbb2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@teolemon teolemon changed the title fix: U.K. id fix: change the id from uk to united-kingdom Nov 9, 2023
@teolemon teolemon changed the title fix: change the id from uk to united-kingdom fix: change the id from en:united-kingdom to en:uk Nov 9, 2023
Copy link

@CloCkWeRX CloCkWeRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. For identifiers, might be worth making sure they all use whatever the current https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes codes are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 butter chickens in country UK, 0 without country filter
3 participants