Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure deterministic releases #54

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Ensure deterministic releases #54

wants to merge 32 commits into from

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Dec 21, 2022 •
edited

  • Technical Changes
  • Details:
    • Run tests in absolute isolation
      • Uses poetry to ensure deterministic builds
      • Uses tox to test builds in isolation

@bonjourmauko bonjourmauko changed the title WIP Ensure deterministic releases Dec 21, 2022
@bonjourmauko bonjourmauko marked this pull request as ready for review December 21, 2022 12:40
@bonjourmauko bonjourmauko force-pushed the add-poetry branch 3 times, most recently from 32ac0d0 to 988b986 Compare December 21, 2022 13:02
benoit-cty
benoit-cty reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the switch to Poetry 👍

.github/workflows/workflow.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.github/workflows/workflow.yml Show resolved Hide resolved
bonjourmauko
bonjourmauko commented Dec 22, 2022
View reviewed changes
.github/workflows/workflow.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@bonjourmauko bonjourmauko requested a review from a team December 23, 2022 15:44
@bonjourmauko bonjourmauko mentioned this pull request Dec 23, 2022
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandcha sandcha Awaiting requested review from sandcha

@benjello benjello Awaiting requested review from benjello

@eraviart eraviart Awaiting requested review from eraviart

@MattiSG MattiSG Awaiting requested review from MattiSG

@benoit-cty benoit-cty Awaiting requested review from benoit-cty

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bonjourmauko @benoit-cty