Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support csv in tuple delete #260

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kindlyturnips
Copy link

Description

Added functionality to delete tuples from .csv files.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@kindlyturnips kindlyturnips requested a review from a team as a code owner February 19, 2024 16:49
Copy link

linux-foundation-easycla bot commented Feb 19, 2024

CLA Missing ID CLA Not Signed

@aaguiarz
Copy link
Member

aaguiarz commented Mar 1, 2024

@kindlyturnips Hi! Could you please sign the EasyCLA, so we can approve/merge?

Thanks!

@kindlyturnips
Copy link
Author

Hi @aaguiarz
I'm sorry I was mistaken when I first submitted the pull and signed it as an individual contributor and not a corporate. It seems OpenFGA is owned by Okta (I am not with the organization), this is what I used to sign the EasyCLA. Was this appropriate?
Thanks for your patience again.

@rhamzeh rhamzeh changed the title Delete tuple csv feat: support csv in tuple delete Mar 6, 2024
@rhamzeh
Copy link
Member

rhamzeh commented Mar 6, 2024

Hi @kindlyturnips - in order to fix the EasyCLA issue, can I ask you to squash your commits into 1?

You can do git rebase -i HEAD~2, it will show you two lines, replace the first pick in the second one with squash.

It would also be great if you can edit your commit message to follow conventional commit format, e.g. feat: support csv in tuple delete

@kindlyturnips
Copy link
Author

Hi @rhamzeh,

Thanks for the corrections, I've made the suggested changes. Please let me know if there is anything else, and again thank you for your patience. This is my first open source contribution and I'm learning alot :)

@rhamzeh
Copy link
Member

rhamzeh commented Mar 6, 2024

Thanks @kindlyturnips! For a first OSS contribution this is great! Kudos! We're so happy you chose OpenFGA for that milestone, and hopefully this will lead you to much more contributions to this project and others ❤️

Some minor feedback to unblock this PR:

  1. EasyCLA is still failing. It seems your commit is signed with your local username that is not tied to your github profile. See here on how to do that. Once that is done, you may need to do a git --ammend
  2. Can you fix the lint issues? You can do that by running make lint locally and resolving any problems that come up (let us know if you need any help with this!)

@kindlyturnips
Copy link
Author

Hi @rhamzeh,
Thanks for the kinds words and encouragement. My local repository somehow got a little jumbled, but I think I straightened everything out. I cleaned up the suggestions from the make lint and the most recent commit should have everything straightened out. If I need to squash it or something else please let me know.
~Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants