This repository has been archived by the owner on May 24, 2022. It is now read-only.
EIP-2929: only add builtin to warm address if they are active #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
changed the title
Oh do tell :) |
vxst
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Indeed "ActivePrecompiles" only includes warm addresses.
Ref: ethereum/go-ethereum@d990f93
|
I can confirm I was able to go past the problematic block after applying this patch. |
rayanht
approved these changes
Apr 15, 2021
paulbalaji
approved these changes
Apr 15, 2021
|
@sorpaas can you rebase that two commint to release/v3.2.1 branch, so that only that change is included into hot patch? |
|
Will do! |
junbeomlee
approved these changes
Apr 15, 2021
|
LGTM |
AgwaB
approved these changes
Apr 15, 2021
|
Its synchronizing good job @sorpaas waiting to be sync and then we can say that was it |
alexprut
approved these changes
Apr 15, 2021
|
LGTM ! |
aramalipoor
approved these changes
Apr 15, 2021
karim-agha
approved these changes
Apr 15, 2021
|
@alexprut 大哥。。。就是找你顺手帮个忙。。100XRP酬谢。。不帮也说一声就好了。。。屏蔽我不至于吧··· |
Conanza00
approved these changes
Sep 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual fix of #353. Added here just for everyone to test. Credits go to the bug finder @holiman!